GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: revert backported commits by MylesBorins · Pull Request #6530 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented May 2, 2016

Copy link
Copy Markdown
Contributor

This reverts changes found in daf3ef6 0943001 that incorrectly
updated the docs for path.format

closes #6437

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins MylesBorins added doc Issues and PRs related to Node.js documentation. v4.x labels May 2, 2016
@MylesBorins

MylesBorins commented May 2, 2016

Copy link
Copy Markdown
Contributor Author

/cc @jasnell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented May 2, 2016

Copy link
Copy Markdown
Member

Yep. Looks fine. I'm thinking at this point we should generally slow down on backporting these proactively. As the delta between master and v4 grows, it's going to become more and more important to have the author of the PR to do the porting if it's to be brought back.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the path Issues and PRs related to the path subsystem. label May 2, 2016
@MylesBorins

MylesBorins commented May 2, 2016

Copy link
Copy Markdown
Contributor Author

+1 to that @jasnell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented May 2, 2016

Copy link
Copy Markdown
Member

In fact, I would even go so far as to say that unless we get a backport PR, we should hold off cherry-picking the commits from here on out. /cc @nodejs/lts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the lts-watch-v4.x label May 2, 2016
@MylesBorins

MylesBorins commented May 2, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell I'd like to do one more pass of things that landed in v5... but after that I think that idea is a++
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented May 4, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins
MylesBorins force-pushed the revert-doc-changes branch from 06ea404 to 7f5fdd8 Compare May 4, 2016 17:04
Myles Borins
doc: revert backported commits
b511c5a 
This reverts changes found in daf3ef6 0943001 that incorrectly
updated the docs for `path.format`

PR-URL: nodejs#6530
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
MylesBorins force-pushed the revert-doc-changes branch from 7f5fdd8 to b511c5a Compare May 4, 2016 17:06
@MylesBorins
MylesBorins merged commit b511c5a into nodejs:v4.x-staging May 4, 2016
MylesBorins pushed a commit that referenced this pull request May 6, 2016
Myles Borins
doc: revert backported commits
8501783 
This reverts changes found in daf3ef6 0943001 that incorrectly
updated the docs for `path.format`

PR-URL: #6530
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
MylesBorins deleted the revert-doc-changes branch May 12, 2016 18:14
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels May 18, 2016
MylesBorins pushed a commit that referenced this pull request May 18, 2016
Myles Borins
doc: revert backported commits
3695690 
This reverts changes found in daf3ef6 0943001 that incorrectly
updated the docs for `path.format`

PR-URL: #6530
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
v4.4.5 proposal #6824
Merged
@imyller imyller mentioned this pull request Sep 16, 2016
Path.format doesn't concat .name and .ext #6437
Closed
@MylesBorins MylesBorins mentioned this pull request Nov 1, 2017
[v8.x] https: revert "refactor to use http internals" #16660
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@MylesBorins @jasnell @mscdex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.