GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add missing return types in buffer.md by inoway46 · Pull Request #65308 · nodejs/node

Conversation

@inoway46

@inoway46 inoway46 commented Aug 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds missing return annotations for the following items:

  • https://beta.docs.nodejs.org/buffer.html#blobbytes
    • lib/internal/blob.js (line 323)
  • https://beta.docs.nodejs.org/buffer.html#blobslicestart-end-type
    • lib/internal/blob.js (line 256)
  • https://beta.docs.nodejs.org/buffer.html#bufferatobdata
    • src/node_buffer.cc (line 1473)
  • https://beta.docs.nodejs.org/buffer.html#bufferbtoadata
    • src/node_buffer.cc (line 1467)

Refs: nodejs/doc-kit#953

Assisted-by: Codex (locating the relevant implementations)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Aug 15, 2026
@inoway46
inoway46 marked this pull request as ready for review August 15, 2026 18:12
@inoway46
inoway46 force-pushed the doc-buffer-return-types branch from ec6f3d8 to 1737910 Compare August 15, 2026 18:15
@inoway46
doc: add missing return types in buffer.md
81ce06d 
Add return types for Blob methods and legacy Base64 helpers so doc-kit
does not render them as `void`.

Refs: nodejs/doc-kit#953
Signed-off-by: inoway46 <[email protected]>
@inoway46
inoway46 force-pushed the doc-buffer-return-types branch from 1737910 to 81ce06d Compare August 15, 2026 18:18
lpinca
lpinca approved these changes Aug 15, 2026
View reviewed changes
trivikr
trivikr approved these changes Aug 18, 2026
View reviewed changes
@trivikr trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ba8cdc2 into nodejs:main Aug 18, 2026
22 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Landed in ba8cdc2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 18, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@inoway46 @aduh95
doc: add missing return types in buffer.md
b0f7069 
Add return types for Blob methods and legacy Base64 helpers so doc-kit
does not render them as `void`.

Refs: nodejs/doc-kit#953
Signed-off-by: inoway46 <[email protected]>
PR-URL: #65308
Refs: nodejs/doc-kit#953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@inoway46 @aduh95
doc: add missing return types in buffer.md
695cd89 
Add return types for Blob methods and legacy Base64 helpers so doc-kit
does not render them as `void`.

Refs: nodejs/doc-kit#953
Signed-off-by: inoway46 <[email protected]>
PR-URL: #65308
Refs: nodejs/doc-kit#953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@inoway46 @aduh95
doc: add missing return types in buffer.md
e9eacdf 
Add return types for Blob methods and legacy Base64 helpers so doc-kit
does not render them as `void`.

Refs: nodejs/doc-kit#953
Signed-off-by: inoway46 <[email protected]>
PR-URL: #65308
Refs: nodejs/doc-kit#953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@inoway46 @aduh95
doc: add missing return types in buffer.md
4533572 
Add return types for Blob methods and legacy Base64 helpers so doc-kit
does not render them as `void`.

Refs: nodejs/doc-kit#953
Signed-off-by: inoway46 <[email protected]>
PR-URL: #65308
Refs: nodejs/doc-kit#953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@inoway46 @nodejs-github-bot @lpinca @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.