GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — quic: mark drain promise handled by jasnell · Pull Request #65319 · nodejs/node

Conversation

jasnell commented Aug 16, 2026

Copy link

Copy Markdown

Member

Fixes: #64290

@nodejs/quic @martenrichter

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          quic: mark drain promise handled

39fa1e0

Fixes: nodejs#64290
Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus

jasnell added this to QUIC Team

Aug 16, 2026

nodejs-github-bot commented Aug 16, 2026

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/quic

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell moved this to Ready for Review in QUIC Team

Aug 16, 2026

nodejs-github-bot added needs-ci

PRs that need a full CI run.

quic Issues and PRs related to the QUIC transport implementation. labels

Aug 16, 2026

nodejs-github-bot commented Aug 16, 2026 •

edited by jasnell

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75874/ 💚

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Aug 16, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (86c871e) to head (39fa1e0).
⚠️ Report is 112 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65319      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files         752      752              
  Lines      251569   251571       +2     
  Branches    47267    47267              
==========================================
- Hits       226738   226715      -23     
- Misses      16184    16201      +17     
- Partials     8647     8655       +8

Files with missing lines	Coverage Δ
lib/internal/quic/quic.js	`100.00% <100.00%> (ø)`

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

martenrichter commented Aug 16, 2026

Copy link

Copy Markdown

Contributor

lgtm Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell requested review from Qard and pimterry

August 16, 2026 13:50

Qard approved these changes

Aug 16, 2026

View reviewed changes

jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Aug 17, 2026

jasnell moved this from Ready for Review to Ready to Land in QUIC Team

Aug 17, 2026

trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label

Aug 22, 2026

nodejs-github-bot merged commit c1d3132 into nodejs:main

Aug 23, 2026

92 of 93 checks passed

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Aug 23, 2026

Copy link

Copy Markdown

Collaborator

Landed in c1d3132

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-project-automation Bot moved this from Ready to Land to Done in QUIC Team

Aug 23, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Aug 23, 2026

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          quic: mark drain promise handled

ad2ac3f

Fixes: #64290
Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          quic: mark drain promise handled

Fixes: #64290
Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <[email protected]>

github-actions Bot mentioned this pull request

Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

aduh95 pushed a commit that referenced this pull request

Aug 27, 2026


          quic: mark drain promise handled

647c8dd

Fixes: #64290
Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <[email protected]>

github-actions Bot mentioned this pull request

Sep 7, 2026

2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873

Merged

aduh95 pushed a commit that referenced this pull request

Sep 7, 2026


          quic: mark drain promise handled

eade9c7

Fixes: #64290
Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <[email protected]>

aduh95 pushed a commit that referenced this pull request

Sep 7, 2026


          quic: mark drain promise handled

a4c770c

Fixes: #64290
Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65319
Reviewed-By: Stephen Belanger <[email protected]>

Reviewers

Qard

Qard approved these changes

pimterry

Awaiting requested review from pimterry

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

needs-ci

PRs that need a full CI run.

quic

Issues and PRs related to the QUIC transport implementation.

Projects

QUIC Team

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

quic: QuicStream writer creates unhandled error

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jasnell commented Aug 16, 2026

Uh oh!

nodejs-github-bot commented Aug 16, 2026

Uh oh!

nodejs-github-bot commented Aug 16, 2026 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

martenrichter commented Aug 16, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Aug 16, 2026 •

edited by jasnell

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Aug 16, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.