GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: simplify timers interval rejection assertion by HoonDongKang · Pull Request #65322 · nodejs/node

Conversation

@HoonDongKang

@HoonDongKang HoonDongKang commented Aug 16, 2026

Copy link
Copy Markdown
Member

Replace a rejection-only try/catch block in
test-timers-interval-promisified.js with assert.rejects().

This simplifies the abort rejection test by verifying both the rejection and
the expected error shape in a single assertion, improving readability without
changing the tested behavior.

Refs:

  • test: simplify test-tls-connect-abort-controller.js #57338
  • implement TLSSocket and connect from node:tls cloudflare/workerd#3594

Tests:

  • ./node test/parallel/test-timers-interval-promisified.js
  • tools/test.py test/parallel/test-timers-interval-promisified.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@HoonDongKang
test: simplify test-timers-interval-promisified.js
4510c52 
Signed-off-by: HoonDongKang <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (ad7a5b8) to head (4510c52).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65322      +/-   ##
==========================================
+ Coverage   90.11%   90.12%   +0.01%     
==========================================
  Files         752      752              
  Lines      251569   251569              
  Branches    47268    47264       -4     
==========================================
+ Hits       226701   226728      +27     
+ Misses      16233    16183      -50     
- Partials     8635     8658      +23

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 16, 2026
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 16, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 17, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75943/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 82e7ff4 into nodejs:main Aug 23, 2026
87 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Landed in 82e7ff4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@HoonDongKang @aduh95
test: simplify test-timers-interval-promisified.js
8bb20bd 
Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65322
Refs: #57338
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@HoonDongKang @aduh95
test: simplify test-timers-interval-promisified.js
30f1a19 
Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65322
Refs: #57338
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@HoonDongKang @aduh95
test: simplify test-timers-interval-promisified.js
5d8194a 
Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65322
Refs: #57338
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@HoonDongKang @aduh95
test: simplify test-timers-interval-promisified.js
01c1263 
Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65322
Refs: #57338
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@HoonDongKang @aduh95
test: simplify test-timers-interval-promisified.js
f38f154 
Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65322
Refs: #57338
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@HoonDongKang @nodejs-github-bot @lpinca @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.