GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — sqlite: remove unused column name helper by trivikr · Pull Request #65401 · nodejs/node

Conversation

@trivikr

@trivikr trivikr commented Aug 19, 2026

Copy link
Copy Markdown
Member

Refs: #65276

Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@trivikr
sqlite: remove unused column name helper
0cfdb00 
Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.

Signed-off-by: Kamat, Trivikram <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr
trivikr requested a review from geeksilva97 August 19, 2026 14:14
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Aug 19, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 19, 2026
@codecov

codecov Bot commented Aug 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (9c641c5) to head (0cfdb00).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65401      +/-   ##
==========================================
- Coverage   90.11%   90.09%   -0.02%     
==========================================
  Files         752      752              
  Lines      252200   252191       -9     
  Branches    47433    47438       +5     
==========================================
- Hits       227267   227222      -45     
- Misses      16239    16277      +38     
+ Partials     8694     8692       -2
Files with missing lines Coverage Δ
src/node_sqlite.cc 82.05% <ø> (+0.24%) ⬆️
src/node_sqlite.h 86.00% <ø> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 20, 2026
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76022/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
geeksilva97
geeksilva97 approved these changes Aug 20, 2026
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76071/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 37e66c4 into nodejs:main Aug 21, 2026
92 of 93 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Landed in 37e66c4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026
@trivikr
trivikr deleted the sqlite-unused-statement-executionhelper branch August 21, 2026 16:00
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@trivikr @aduh95
sqlite: remove unused column name helper
f629323 
Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.

Signed-off-by: Kamat, Trivikram <[email protected]>
PR-URL: #65401
Refs: #65276
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@trivikr @aduh95
sqlite: remove unused column name helper
60cb384 
Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.

Signed-off-by: Kamat, Trivikram <[email protected]>
PR-URL: #65401
Refs: #65276
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@geeksilva97 geeksilva97 geeksilva97 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@trivikr @nodejs-github-bot @jasnell @geeksilva97
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.