GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: improve nix-changes coverage by aduh95 · Pull Request #65403 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Aug 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

nix-changes was not tracking a few deps, either because they are associated with a disabled-by-default feature (e.g. QUIC), or some of them are loaded only when shared deps are disabled (e.g. Cargo, rustc). The V8 specific ones were also missing. FWIW here's the full list (for aarch64-darwin):

/nix/store/xnf2hlnjmmi59r6c1nzy018759xlp5pk-cargo-1.97.1
/nix/store/cvmhxg0ac3pvrc1xnrrzf9wzd93h1xp9-mock-ada.pc
/nix/store/6zjwbncmf5c6jvhn8ks4v0ikwv41z287-mock-gtest.pc
/nix/store/r1adn84shdm3xbl5i675yprpya5d76cx-mock-hdr_histogram.pc
/nix/store/pbhrzg1rxlrldz52ixwww7n51iy4p10i-mock-libbrotlidec.pc
/nix/store/1m3c56c3ly0lgn8b32j6656gaabvh4qj-mock-libbrotlienc.pc
/nix/store/127lkkhf4l5nf4lrmh0fri8xjvh69v6m-mock-libcares.pc
/nix/store/7zd53bzx6ps0kx9a1cqqpznhjrbzvgr8-mock-libllhttp.pc
/nix/store/jhcnx5hain2l2dcmfii79vhrghngvx07-mock-libnghttp2.pc
/nix/store/q18hrd66ganw7ywlzw553vm95hvymcm7-mock-libnghttp3.pc
/nix/store/8gc50b10s7s9kh8ism2s6ls81ncmmdmj-mock-libngtcp2.pc
/nix/store/c16rc2r8i4xmmv150dvbya9jkcs2csif-mock-libuv.pc
/nix/store/vljl715yrnzgkfy7dcdb9mww3s8n77c7-mock-libzstd.pc
/nix/store/vgknfwwzyb43fml6pal11idvnlg0rb6m-mock-merve.pc
/nix/store/jgijp74zxrc05h92fsfdjdda9spny71a-mock-nbytes.pc
/nix/store/bf6f0bxg87p2waqkbkzwvb0ii9h315f3-mock-simdjson.pc
/nix/store/pl4096rffia5bnifcihvs5lnvs2r28zv-mock-uvwasi.pc
/nix/store/kvj6kinf8i68j4s8gmrh98xcr9zp2d0c-mock-zlib.pc
/nix/store/p3az4xy8h1dmbfqmk4bkk554nk2hnn6h-nghttp3-1.16.0-doc
/nix/store/c4kj460dxdmh2yf0cm137id0dbr6il1s-ngtcp2-1.23.0-doc
/nix/store/w9b2fv3j3azynl03gv5k38lh5cp2bf87-non-v8-deps-mock-0.0.0-mock
/nix/store/i2h5jr4mlziqbsm3jblp88z9jgw5dbf3-patchutils-0.3.4
/nix/store/8wmdpik778pdqqz3azmz93b0f4wyi30m-pkg-config-0.29.2
/nix/store/lqahvywm9fgdhi7lwz4y56dkamsg7z0s-pkg-config-wrapper-0.29.2
/nix/store/jinvhlljv474cr5640ywd5c124kgp8sc-rustc-1.97.1
/nix/store/sznk0bnbp1s4gn4an0a3405wvg4nxjfj-rustc-1.97.1-doc
/nix/store/iz85qysxs639gy77463yhn1259znvzdq-rustc-1.97.1-man
/nix/store/sbrjwqjkbc07drlcni93y51jlcmll8kq-rustc-wrapper-1.97.1
/nix/store/zyvpf2x8hfp3gl6561zr8fa6qkzqcj08-rustc-wrapper-1.97.1-doc
/nix/store/mlg531ry8nj53w0pl8n58hgyd07g8nld-rustc-wrapper-1.97.1-man
/nix/store/glh75y9a0a4pdzfzyj0n5nn1gn96451d-temporal_capi-0.2.5
/nix/store/jh80m54hnwvpbv43hhr5lrqbbakkpbrz-validate-pkg-config

I'm moving it to a separate script so it can be linted, and hopefully is more readable. That should also remove the need for #64967 as the script would be affected by git reset HEAD^ --hard

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
tools: improve nix-changes coverage
da1641a 
Signed-off-by: Antoine du Hamel <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 19, 2026
aduh95 added 7 commits August 19, 2026 18:30
@aduh95
fixup! tools: improve nix-changes coverage
000c3b9
@aduh95
fixup! tools: improve nix-changes coverage
2d7e6fc
@aduh95
fixup! tools: improve nix-changes coverage
1320a13
@aduh95
fixup! tools: improve nix-changes coverage
72c9476
@aduh95
fixup! tools: improve nix-changes coverage
fa9a024
@aduh95
fixup! tools: improve nix-changes coverage
2029e3c
@aduh95
fixup! tools: improve nix-changes coverage
d09f06a
jasnell
jasnell approved these changes Aug 20, 2026
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 20, 2026
@aduh95
aduh95 requested a review from panva August 20, 2026 07:40
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 20, 2026
panva
panva approved these changes Aug 20, 2026
View reviewed changes
@nodejs-github-bot
nodejs-github-bot merged commit ce1e0d5 into nodejs:main Aug 21, 2026
50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Landed in ce1e0d5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026
aduh95 added a commit that referenced this pull request Aug 25, 2026
@aduh95
tools: improve nix-changes coverage
8ed50f0 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #65403
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
aduh95 added a commit that referenced this pull request Aug 25, 2026
@aduh95
tools: improve nix-changes coverage
78175c6 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #65403
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
@aduh95
aduh95 deleted the list-requisites.sh branch August 26, 2026 09:45
@aduh95 aduh95 mentioned this pull request Aug 26, 2026
[v26.x] tools: fix nix/list-requisites.sh #65560
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Aug 26, 2026
@aduh95
tools: improve nix-changes coverage
efd2c98 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#65403
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
aduh95 added a commit that referenced this pull request Aug 26, 2026
@aduh95
tools: fix tools/nix/list-requisites.sh
0b0dd87 
PR-URL: #65560
Refs: #65403
Reviewed-By: Filip Skokan <[email protected]>
Signed-off-by: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @panva @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.