GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix broken GYP link in n-api.md by HoonDongKang · Pull Request #65413 · nodejs/node

Conversation

@HoonDongKang

@HoonDongKang HoonDongKang commented Aug 20, 2026

Copy link
Copy Markdown
Member

Fixed the broken GYP link in n-api.md.

The gyp.gsrc.io` website is no longer available, so the link has been replaced with the GYP documentation preserved in the Chromium Google Source repository.

-[GYP]: https://gyp.gsrc.io
+[GYP]: https://chromium.googlesource.com/external/gyp/+/refs/heads/md-pages/index.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@HoonDongKang
doc: fix broken GYP link in n-api.md
8c91601 
Replace the unavailable GYP website with the GYP documentation
preserved in the Chromium source repository.

Signed-off-by: HoonDongKang <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API. labels Aug 20, 2026
@github-project-automation github-project-automation Bot added this to Node-API Team Project Aug 20, 2026
@github-project-automation github-project-automation Bot moved this to Need Triage in Node-API Team Project Aug 20, 2026
@HoonDongKang HoonDongKang mentioned this pull request Aug 20, 2026
doc: update outdated nodejs.org guide links #65394
Merged
legendecas
legendecas reviewed Aug 20, 2026
View reviewed changes

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update

node/doc/api/n-api.md

Lines 197 to 198 in 5ba7e05

[node-gyp][] is a build system based on the [gyp-next][] fork of
Google's [GYP][] tool and comes bundled with npm. GYP, and therefore node-gyp,

to

[node-gyp][] is a build system based on the [gyp-next][] tool and comes bundled with npm.

The linked google repo is not maintained anyway.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Aug 20, 2026
View reviewed changes
avivkeller
avivkeller approved these changes Aug 21, 2026
View reviewed changes
@avivkeller avivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 21, 2026
@legendecas legendecas removed author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 21, 2026
@legendecas

legendecas commented Aug 21, 2026

Copy link
Copy Markdown
Member

Please remove the link as the suggestion: #65413 (review), thanks!
HoonDongKang reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@HoonDongKang
doc: remove unmaintained GYP link from n-api
95ec967 
Google's GYP project is no longer maintained.

Signed-off-by: HoonDongKang <[email protected]>
@HoonDongKang

HoonDongKang commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Sorry for the late response.

I removed the link and updated the wording as suggested. I also retained the note that node-gyp requires Python, which wasn’t included in the suggestion.

+ node-gyp requires that Python be installed.

Thank you!
legendecas reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Aug 22, 2026
View reviewed changes
@legendecas legendecas added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 1db6cda into nodejs:main Aug 22, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in 1db6cda
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 22, 2026
@github-project-automation github-project-automation Bot moved this from Need Triage to Done in Node-API Team Project Aug 22, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@HoonDongKang @aduh95
doc: fix broken GYP link in n-api.md
d0aa5a1 
Replace the unavailable GYP website with the GYP documentation
preserved in the Chromium source repository.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65413
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@HoonDongKang @aduh95
doc: fix broken GYP link in n-api.md
1ad09f7 
Replace the unavailable GYP website with the GYP documentation
preserved in the Chromium source repository.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65413
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@HoonDongKang @aduh95
doc: fix broken GYP link in n-api.md
ed69a21 
Replace the unavailable GYP website with the GYP documentation
preserved in the Chromium source repository.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65413
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@HoonDongKang @aduh95
doc: fix broken GYP link in n-api.md
5de6694 
Replace the unavailable GYP website with the GYP documentation
preserved in the Chromium source repository.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65413
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@HoonDongKang @aduh95
doc: fix broken GYP link in n-api.md
b13f425 
Replace the unavailable GYP website with the GYP documentation
preserved in the Chromium source repository.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65413
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@legendecas legendecas legendecas approved these changes
@avivkeller avivkeller avivkeller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API.

Projects

Node-API Team Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@HoonDongKang @nodejs-github-bot @legendecas @lpinca @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.