GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — perf_hooks: add statistical hypothesis testing to histogram by jasnell · Pull Request #65416 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Aug 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Continue expanding the capabilities of the Histogram API... and use it to enable a dependency-free benchmark/compare.js option... i.e. no longer requiring R-script to show benchmark analysis... just run benchmark/compare.js with the --analyze option.

The added algorithms cover analysis calculations that would be fairly common in perf analysis (latency, burn rates, detecting regressions, etc). Prior to this, really the only way to get these were to use aging outside dependencies (5+ years old) or R-script.

Just scratching an old itch I've been wanting since I added Histogram back in v11. I've been doing a bunch of benchmarking lately with the QUIC and DTLS impls and just got tired of having to use outside deps for this stuff.

/cc @mcollina

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell
jasnell requested review from Qard and mcollina August 20, 2026 06:25
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 20, 2026
@jasnell
jasnell force-pushed the jasnell/more-histogram-fun branch from f866877 to bc4d71e Compare August 20, 2026 13:24
@jasnell jasnell mentioned this pull request Aug 20, 2026
perf_hooks: add binary export/import to Histogram #65434
Closed
@codecov

codecov Bot commented Aug 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.44262% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (cc57cb7) to head (fedf4f2).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/histogram.cc 90.76% 4 Missing and 30 partials ⚠️
src/histogram-inl.h 86.36% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65416      +/-   ##
==========================================
+ Coverage   90.12%   90.14%   +0.02%     
==========================================
  Files         751      751              
  Lines      252536   253137     +601     
  Branches    47519    47631     +112     
==========================================
+ Hits       227598   228191     +593     
+ Misses      16250    16202      -48     
- Partials     8688     8744      +56     
Files with missing lines Coverage Δ
lib/internal/histogram.js 96.09% <100.00%> (+1.32%) ⬆️
src/histogram.h 68.42% <ø> (ø)
src/histogram-inl.h 84.45% <86.36%> (+2.21%) ⬆️
src/histogram.cc 84.62% <90.76%> (+2.83%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina
mcollina approved these changes Aug 20, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell force-pushed the jasnell/more-histogram-fun branch from bc4d71e to 54c4c56 Compare August 20, 2026 19:19
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell

jasnell commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

/cc @nodejs/performance

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 20, 2026
legendecas
legendecas approved these changes Aug 20, 2026
View reviewed changes
Comment thread lib/internal/histogram.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jasnell
jasnell force-pushed the jasnell/more-histogram-fun branch from 54c4c56 to 0793579 Compare August 20, 2026 20:35
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Aug 20, 2026
legendecas
legendecas approved these changes Aug 20, 2026
View reviewed changes
@jasnell jasnell added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell

jasnell commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

Notes for the notable change:

This PR expands the analytical capabilities of Histogram further by adding EWMA, cliffsD, cohensD, SLO burn rate, mannWhitneyTest, and percentile confidence intervals to the API. Notably, this provides the ability to perform performance benchmark analysis directly within Node.js with no dependencies.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell added 2 commits August 22, 2026 23:07
@jasnell
perf_hooks: add statistical hypothesis testing to histogram
08bbd28
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
@jasnell
benchmark: add --analyze mode to compare.js
fedf4f2
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
@jasnell
jasnell force-pushed the jasnell/more-histogram-fun branch from 0793579 to fedf4f2 Compare August 22, 2026 23:07
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76295/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell added a commit that referenced this pull request Aug 23, 2026
@jasnell
perf_hooks: add statistical hypothesis testing to histogram
524dee4
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
jasnell added a commit that referenced this pull request Aug 23, 2026
@jasnell
benchmark: add --analyze mode to compare.js
bf67fdc
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@jasnell

jasnell commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

Landed in c28857e...bf67fdc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell jasnell closed this Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@jasnell @aduh95
perf_hooks: add statistical hypothesis testing to histogram
34626f0
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@jasnell @aduh95
benchmark: add --analyze mode to compare.js
568367e
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@jasnell @aduh95
perf_hooks: add statistical hypothesis testing to histogram
9e8e908
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@jasnell @aduh95
benchmark: add --analyze mode to compare.js
74234ee
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
nodejs-github-bot added a commit that referenced this pull request Aug 25, 2026
@nodejs-github-bot
2026-08-26, Version 26.8.0 (Current)
2161c94
Notable changes:

benchmark:
  * (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
  * mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
  * add basic syntax highlighting (Aviv Keller) #64591
sqlite:
  * (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
  * (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
  * (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
  * (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339

PR-URL: #65551
aduh95 pushed a commit that referenced this pull request Aug 26, 2026
@nodejs-github-bot @aduh95
2026-08-26, Version 26.8.0 (Current)
30542c3
Notable changes:

benchmark:
  * (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) enable SIV and GCM-SIV modes in Cipher/Decipher APIs (Filip Skokan) #63411
diagnostics_channel:
  * mark TracingChannel as stable (Abdelrahman Awad) #64525
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
repl:
  * add basic syntax highlighting (Aviv Keller) #64591
sqlite:
  * (SEMVER-MINOR) add StatementSync.prototype.close() (Guilherme Araújo) #64232
  * (SEMVER-MINOR) add StatementSync.prototype[Symbol.dispose]() (Guilherme Araújo) #64232
util:
  * (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965
zlib:
  * (SEMVER-MINOR) add ZipEntry, ZipFile, and ZipBuffer (Philipp Dunkel) #64339

PR-URL: #65551
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@jasnell @aduh95
perf_hooks: add statistical hypothesis testing to histogram
8076683
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@jasnell @aduh95
benchmark: add --analyze mode to compare.js
6a04f7d
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
nodejs-github-bot added a commit that referenced this pull request Sep 7, 2026
@nodejs-github-bot
2026-09-08, Version 24.21.0 'Krypton' (LTS)
69505d7
Notable changes:

benchmark:
  * (SEMVER-MINOR) add --analyze mode to compare.js (James M Snell) #65416
crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of net.BlockList (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
util:
  * (SEMVER-MINOR) add non-throwing MIMEType.parse (James M Snell) #64965

PR-URL: #65873
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@jasnell @aduh95
perf_hooks: add statistical hypothesis testing to histogram
b9d7a50
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@jasnell @aduh95
benchmark: add --analyze mode to compare.js
d47f1b0
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
2026-09-08, Version 24.21.0 'Krypton' (LTS)
a76b285
Notable changes:

crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
deps:
  * update OpenSSL to 3.5.8 (Node.js GitHub Bot) #65542
  * update Undici to 7.29.1 (Node.js GitHub Bot) #65789
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of `net.BlockList` (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
util:
  * (SEMVER-MINOR) add non-throwing `MIMEType.parse` (James M Snell) #64965

PR-URL: #65873
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@jasnell @aduh95
perf_hooks: add statistical hypothesis testing to histogram
5197b5a
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta,
and and handful of others

These methods enable in-process benchmark comparison and regression
detection without external dependencies.

No new dependencies.

Tests and docs created by the AI agent.

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@jasnell @aduh95
benchmark: add --analyze mode to compare.js
90d127d
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.

When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.

Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.

Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.

Usage:
  node benchmark/compare.js --old ./node-old --new ./node-new \
    --analyze url

Signed-off-by: James M Snell <[email protected]>
Assisted-by: Opencode/Opus
PR-URL: #65416
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
2026-09-08, Version 24.21.0 'Krypton' (LTS)
955266b
Notable changes:

crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
deps:
  * update OpenSSL to 3.5.8 (Node.js GitHub Bot) #65542
  * update Undici to 7.29.1 (Node.js GitHub Bot) #65789
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of `net.BlockList` (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
util:
  * (SEMVER-MINOR) add non-throwing `MIMEType.parse` (James M Snell) #64965

PR-URL: #65873
aduh95 added a commit that referenced this pull request Sep 8, 2026
@aduh95
2026-09-08, Version 24.21.0 'Krypton' (LTS)
9afe7dc
Notable changes:

crypto:
  * update root certificates to NSS 3.126 (Node.js GitHub Bot) #65495
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
deps:
  * update OpenSSL to 3.5.8 (Node.js GitHub Bot) #65542
  * update Undici to 7.29.1 (Node.js GitHub Bot) #65789
lib,src:
  * (SEMVER-MINOR) improve histogram implementation (James M Snell) #65024
net:
  * (SEMVER-MINOR) improve performance of `net.BlockList` (James M Snell) #64974
perf_hooks:
  * (SEMVER-MINOR) add statistical hypothesis testing to histogram (James M Snell) #65416
util:
  * (SEMVER-MINOR) add non-throwing `MIMEType.parse` (James M Snell) #64965

PR-URL: #65873
@github-actions github-actions Bot mentioned this pull request Sep 9, 2026
chore(deps): update dependency node to v24.21.0 tailor-platform/sdk#2309
Merged
1 task
@SimonSchick SimonSchick mentioned this pull request Oct 10, 2026
feat: backfill various missing node APIs DefinitelyTyped/DefinitelyTyped#75760
Open
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@legendecas legendecas legendecas approved these changes
@Qard Qard Awaiting requested review from Qard

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jasnell @nodejs-github-bot @mcollina @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.