GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: run known_issues tests in CI by Trott · Pull Request #6559 · nodejs/node

Conversation

@Trott

@Trott Trott commented May 4, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Add known_issues tests to make test and make test-ci targets and
their equivalents on Windows.

This should not land until #6555 lands first. (#6555 landed, woot.)

/cc @cjihrig @Fishrock123 @nodejs/testing ... and whoever the Python folks are who can tell me if I'm Doing It Wrong in testcfg.py... @thefourtheye? @bnoordhuis? @jbergstroem? Someone else?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fishrock123 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Trott
test: run known_issues tests in CI
a32f6b2 
Add `known_issues` tests to `make test` and `make test-ci` targets and
their equivalents on Windows.
@Trott Trott added test Issues and PRs related to Node.js core tests and test infrastructure. wip Issues and PRs that are still a work in progress. labels May 4, 2016
@Trott

Trott commented May 4, 2016

Copy link
Copy Markdown
Member Author

Added the in progress flag so that @jasnell et al. don't bother having to read the description to find out that they shouldn't land this until #6555 lands first.
jasnell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the known issue test label May 4, 2016
@jasnell

jasnell commented May 4, 2016

Copy link
Copy Markdown
Member

Appreciate it! Use of the labels really helps save time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orangemocha

orangemocha commented May 5, 2016

Copy link
Copy Markdown
Contributor

cc @joaocgreis
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott removed the wip Issues and PRs that are still a work in progress. label May 6, 2016
@Trott

Trott commented May 6, 2016

Copy link
Copy Markdown
Member Author

#6555 landed, which means this can land, so I'm removing the in progress label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 6, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2519/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 6, 2016

Copy link
Copy Markdown
Member Author

Single test failure in CI looks unrelated. Opened an "investigate flaky test" issue for it. Re-running CI: https://ci.nodejs.org/job/node-test-pull-request/2521/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 6, 2016

Copy link
Copy Markdown
Member Author

CI is green.

/bump @nodejs/collaborators
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented May 6, 2016

Copy link
Copy Markdown
Contributor

LGTM, but I'm not comfortable being the only sign off on Python code :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented May 6, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit to Trott/io.js that referenced this pull request May 6, 2016
@Trott
test: run known_issues tests in CI
5d0b1f4 
Add `known_issues` tests to `make test` and `make test-ci` targets and
their equivalents on Windows.

PR-URL: nodejs#6559
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott

Trott commented May 6, 2016

Copy link
Copy Markdown
Member Author

Landed in 5d0b1f4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this May 6, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@Trott @evanlucas
test: run known_issues tests in CI
be241c3 
Add `known_issues` tests to `make test` and `make test-ci` targets and
their equivalents on Windows.

PR-URL: #6559
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@evanlucas evanlucas mentioned this pull request May 17, 2016
2016-05-17, Version 6.2.0 (Stable) #6810
Merged
@MylesBorins

MylesBorins commented Jun 2, 2016

Copy link
Copy Markdown
Contributor

@Trott lts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added the lts-watch-v4.x label Jun 2, 2016
@Trott

Trott commented Jun 2, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd Yes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Jun 3, 2016
@MylesBorins

MylesBorins commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

@Trott does not land cleanly.. feel free to backport
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 3, 2016

Copy link
Copy Markdown
Member Author

It's not essential. I'm OK with leaving it out.
MylesBorins reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hybrist hybrist mentioned this pull request Apr 6, 2017
test: Update information on known_issues #12262
Closed
3 tasks done
aqrln pushed a commit that referenced this pull request Apr 9, 2017
Jan Krems @aqrln
doc: update information on test/known_issues
1807080 
* Since #6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: #12262
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
Jan Krems Italo A. Casas
doc: update information on test/known_issues
2f9e2fc 
* Since nodejs#6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: nodejs#12262
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
Jan Krems @MylesBorins
doc: update information on test/known_issues
663a1ec 
* Since #6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: #12262
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Jan Krems @MylesBorins
doc: update information on test/known_issues
88f402c 
* Since #6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: #12262
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Jan Krems @andrew749
doc: update information on test/known_issues
1cb3cea 
* Since nodejs/node#6559 known_issues
  does run on CI.
* Add some notes to explain the expectations around tests in
  known_issues.

PR-URL: nodejs/node#12262
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Trott deleted the cnown branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @jasnell @orangemocha @cjihrig @addaleax @MylesBorins @mscdex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.