GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: add missing vector include by panva · Pull Request #65622 · nodejs/node

Conversation

@panva

@panva panva commented Aug 28, 2026

Copy link
Copy Markdown
Member

Fixes: #65620

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tuzi3040 reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@panva
src: add missing vector include
da40c93 
Signed-off-by: Filip Skokan <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Aug 28, 2026
pimterry
pimterry approved these changes Aug 28, 2026
View reviewed changes
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 28, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 28, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
lpinca
lpinca approved these changes Aug 28, 2026
View reviewed changes
@Renegade334 Renegade334 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 28, 2026
Renegade334
Renegade334 approved these changes Aug 28, 2026
View reviewed changes
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Renegade334. Please 👍 to approve.
panva reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76681/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2026
jasnell
jasnell approved these changes Aug 29, 2026
View reviewed changes
@nodejs-github-bot
nodejs-github-bot merged commit f7e2c14 into nodejs:main Aug 30, 2026
88 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Landed in f7e2c14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 30, 2026
aduh95 pushed a commit that referenced this pull request Sep 3, 2026
@panva @aduh95
src: add missing vector include
527f148 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #65622
Fixes: #65620
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@panva panva mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
@panva
panva deleted the issue-65620 branch September 7, 2026 08:16
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@panva @aduh95
src: add missing vector include
e000e4c 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #65622
Fixes: #65620
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@panva @aduh95
src: add missing vector include
e3c6bd6 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #65622
Fixes: #65620
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Version 26.9.0 (Current) #65881
Merged
aduh95 pushed a commit that referenced this pull request Sep 15, 2026
@panva @aduh95
src: add missing vector include
0650dca 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #65622
Fixes: #65620
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tuzi3040 tuzi3040 mentioned this pull request Sep 17, 2026
node 26.9.0 Homebrew/homebrew-core#311579
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@pimterry pimterry pimterry approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node 26.8.1 build failure

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@panva @nodejs-github-bot @jasnell @lpinca @pimterry @Renegade334
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.