GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: upgrade to V8 5.0.71.47 by ofrobots · Pull Request #6572 · nodejs/node

Conversation

@ofrobots

@ofrobots ofrobots commented May 4, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

Pick up the latest set of patch level updates from the V8 5.0 branch.
v8/v8@5.0.71.35...5.0.71.47

R= @nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/2497/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ChALkeR, bricss, and nfantone reacted with hooray emoji
All reactions
  • 🎉 3 reactions
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 4, 2016
This was referenced May 4, 2016
deps: backport 8eda85d from v8 upstream #6424
Closed
deps: backport e093a04, 09db540 from upstream V8 #6398
Closed
@bnoordhuis

bnoordhuis commented May 4, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented May 4, 2016

Copy link
Copy Markdown
Member

CI run of v8 tests in node tree: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/78/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JungMinu

JungMinu commented May 5, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ofrobots

ofrobots commented May 6, 2016

Copy link
Copy Markdown
Contributor Author

@mhdawson Do you know what is going on with the benchmark,v8test configuration in that v8 tests build? Seems to be breaking since build 76. Is it a flake?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented May 9, 2016

Copy link
Copy Markdown
Member

This issue is tracking the known failure in the v8 runs: #6340 which is intermittent.

The failures seen in the one with the update is not obviously related from the output, however, in our internal builds we saw similar failures on AIX and the case was regress/regress-crbug-514081
So its almost certainly the same issue.

I'm going to submit a PR to limit execution of this test 1 one variant.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented May 10, 2016

Copy link
Copy Markdown
Member

PR to address regress/regress-crbug-514081 failures - #6678
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ofrobots
deps: upgrade to V8 5.0.71.47
e16e611 
Pick up the latest set of patch level updates from the V8 5.0 branch.
v8/v8@5.0.71.35...5.0.71.47

PR-URL: nodejs#6572
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: JungMinu - Minwoo Jung <[email protected]>
@ofrobots
ofrobots force-pushed the 5.0.71.47 branch from 79d8a9f to e16e611 Compare May 12, 2016 01:49
@ofrobots
ofrobots merged commit e16e611 into nodejs:master May 12, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@ofrobots @evanlucas
deps: upgrade to V8 5.0.71.47
a6ca5e5 
Pick up the latest set of patch level updates from the V8 5.0 branch.
v8/v8@5.0.71.35...5.0.71.47

PR-URL: #6572
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: JungMinu - Minwoo Jung <[email protected]>
@evanlucas evanlucas mentioned this pull request May 17, 2016
2016-05-17, Version 6.2.0 (Stable) #6810
Merged
evanlucas added a commit that referenced this pull request May 17, 2016
@evanlucas
2016-05-17, Version 6.2.0 (Stable)
a4705f6 
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)

As of this release the 6.X line now includes 64-bit binaries for Linux
on Power Systems running in big endian mode in addition to the existing
64-bit binaries for running in little endian mode.

PR-URL: #6810
evanlucas added a commit that referenced this pull request May 17, 2016
@evanlucas
2016-05-17, Version 6.2.0 (Stable)
26120e2 
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)

As of this release the 6.X line now includes 64-bit binaries for Linux
on Power Systems running in big endian mode in addition to the existing
64-bit binaries for running in little endian mode.

PR-URL: #6810
@blake-regalia blake-regalia mentioned this pull request May 18, 2016
Internal Error: Illegal Access node-inspector/node-inspector#864
Open
@MylesBorins MylesBorins added the dont-land-on-v4.x label Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ofrobots @bnoordhuis @mhdawson @JungMinu @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.