GeezerVison

LGTM if CI is green.

CI: https://ci.nodejs.org/job/node-test-pull-request/2675/

This should be backported to v5.

There are some failures on freebsd and smartos, I think they are transient, rerunning: https://ci.nodejs.org/job/node-test-pull-request/2697/

LGTM but bonus points if you also add a fix + regression test for the empty array case. It's okay to do it in a separate commit because it's arguably a separate issue.

Aside: I'm slightly surprised the linter accepts the assign-in-if syntax. But if the linter is okay with it, then I am, too.

@bnoordhuis done, I'm adding an empty buffer if the array is empty, or do you think that throwing will be better?

CI: https://ci.nodejs.org/job/node-test-pull-request/2699/.

A small nit about the first commit: the first line of the commit log should be <= 50 characters.

While you're working on send(), can I suggest introducing a local variable called e.g. list? Replacing the buffer argument with the processed result is less clear, IMO.

@bnoordhuis update with the nit you asked!

Let me know if you are ok with this, and I'll land it.

@santigimeno I've updated the tests.

BTW, should we kick off @nodejs/dgram?

Let me know if anybody would like to change anything else :)

These looks like 4 independent commits, what metadata should I apply to those in the message editing phase?

CI: https://ci.nodejs.org/job/node-test-pull-request/2702/

There are failures on the OS X and ARM buildbots. The FreeBSD test failure appears to be unrelated.

@bnoordhuis addressed your nits.

new CI: https://ci.nodejs.org/job/node-test-pull-request/2735/

LGTM with comment. Was your plan to squash the last two commits into the first two?

@bnoordhuis I still see 4 commits, or maybe I did some mistake on git and github is not picking that up.

CI: https://ci.nodejs.org/job/node-test-pull-request/2736/

I did a couple of fix to avoid some flakyness.

new CI: https://ci.nodejs.org/job/node-test-pull-request/2737/
(test was failing in the previous one)

new new CI: https://ci.nodejs.org/job/node-test-pull-request/2739/
(sigh, lots of unrelated failures on SmartOS & others :/)

Again with some changes: https://ci.nodejs.org/job/node-test-pull-request/2740/

@nodejs/build can you please have a look at the 'parallel/test-dgram-send-empty-array ' test in this PR on OS X? I think it should pass, but it is currently failing and I cannot understand why. I've run it thousands of times here and I got zero failures.

This is the last run: https://ci.nodejs.org/job/node-test-commit-osx/3487/nodes=osx1010/tapTestReport/

Any chance that this is nodejs/node-v0.x-archive#8023 resurfacing? You could try removing the skip in https://github.com/nodejs/node/blob/master/test/parallel/test-dgram-empty-packet.js and running the CI on OS X.

@cjihrig it should be it. Maybe the CI box is not running El Capitan?

Thanks @cjihrig for the support, that was it.

New CI with the fix: https://ci.nodejs.org/job/node-test-pull-request/2770/

ci passing, @jasnell @bnoordhuis please give a last pass before I merge.

LGTM but I only gave it a real quick look-over this time around.

CI after rebase https://ci.nodejs.org/job/node-test-pull-request/2777/ (didn't apply cleanly)

LGTM

@mcollina ... saw your question in IRC re: squashing the commits or not.... I would go ahead and squash before landing

Landed as c14e98b.

@mcollina lts?

@thealphanerd this depends on #4374, which hasn't been ported yet. I'm 👍 on both.

I'm going to assume that #4374 will not land in LTS as it does not increase stability. As such I will label this as don't land for now.
Please feel free to open a backport PR or issue on the LTS repo so the WG can discuss it if you think we should include it in v4.5.0

I'm neutral, the only reason to have it on the v4 like is to encourage adoption of this API. It's not that useful with support only on v5 and v6. But, I agree with you that it does not increase stability.