GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — inspector: process.exit should wait for inspector by eugeneo · Pull Request #7252 · nodejs/node

Conversation

@eugeneo

@eugeneo eugeneo commented Jun 9, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

Waits for the inspector frontend to detach when process.exit is called. This enables the user to analyse the profiling information.

Fixes: #7088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 9, 2016
@eugeneo

eugeneo commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

@ofrobots
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pavelfeldman

pavelfeldman commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ofrobots

ofrobots commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/2967/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Jun 10, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Jun 10, 2016

Copy link
Copy Markdown
Member

For bonus points: factor out that magic number 32 into a constant and update PlatformInit() and WaitForInspectorDisconnect().
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eugeneo

eugeneo commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis I introduced a constant and rebased the CL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis reviewed Jun 10, 2016
View reviewed changes
Comment thread src/node.cc Outdated

@bnoordhuis bnoordhuis Jun 10, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name it e.g. kNumSignals or kMaxSignal? ALL_CAPS should be reserved for macros. LGTM apart from that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Eugene Ostroukhov
inspector: process.exit should wait for inspector
f32f1d9 
Fixes: #7088
@eugeneo

eugeneo commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis I renamed to kMaxSignal. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ofrobots

ofrobots commented Jun 10, 2016

Copy link
Copy Markdown
Contributor

New CI: https://ci.nodejs.org/job/node-test-pull-request/2982/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Jun 11, 2016

Copy link
Copy Markdown
Member

LGTM. ppcbe-ubuntu1404 seems to be stuck but everything else is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ofrobots

ofrobots commented Jun 13, 2016

Copy link
Copy Markdown
Contributor

Thanks, landed as 6626919.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ofrobots ofrobots closed this Jun 13, 2016
ofrobots pushed a commit that referenced this pull request Jun 13, 2016
Eugene Ostroukhov @ofrobots
inspector: process.exit should wait for inspector
6626919 
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
@evanlucas evanlucas added the dont-land-on-v6.x label Jun 16, 2016
@evanlucas

evanlucas commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

I am excluding this one from the next v6.x release since it is just a semver patch release. Once the inspector lands in v6.x, we can remove the dont-land-on-v6.x label. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123 Fishrock123 removed the dont-land-on-v6.x label Jul 5, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Eugene Ostroukhov @Fishrock123
inspector: process.exit should wait for inspector
88b2aa3 
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>

 Conflicts:
	src/node.cc
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Propose v6.3.0 (v2) #7550
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Audit commits not found on v4.x-staging #7661
Closed
@MylesBorins MylesBorins added the dont-land-on-v4.x label Jul 11, 2016
@alexdima alexdima mentioned this pull request Aug 25, 2017
debugger doesnt stop when exiting extension development host microsoft/vscode#32990
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--inspect connection dies before profiler captures trace

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@eugeneo @pavelfeldman @ofrobots @bnoordhuis @evanlucas @MylesBorins @Fishrock123 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.