GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: fix --without-inspector build by addaleax · Pull Request #7258 · nodejs/node

Conversation

addaleax commented Jun 10, 2016

Copy link

Copy Markdown

Member

Checklist

make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
the commit message follows commit guidelines

Affected core subsystem(s)

src (v8_inspector?)

Description of change

use_inspector is not available if HAVE_INSPECTOR is false. Before this commit, one usage of it would show up as an undeclared identifier (introduced in a766ebf).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          src: fix --without-inspector build

a5ec950

`use_inspector` is not available if `HAVE_INSPECTOR` is false.
Before this commit, one usage of it would show up as an undeclared
identifier (introduced in a766ebf).

addaleax added c++

Issues and PRs that require attention from people who are familiar with C++.

inspector Issues and PRs related to the V8 inspector protocol. labels

Jun 10, 2016

addaleax commented Jun 10, 2016

Copy link

Copy Markdown

Member Author

CI: https://ci.nodejs.org/job/node-test-commit/3708/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis mentioned this pull request

Jun 10, 2016

Add --without-intl builds to CI matrix nodejs/build#419

Closed

bnoordhuis commented Jun 10, 2016

Copy link

Copy Markdown

Member

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

cjihrig commented Jun 13, 2016

Copy link

Copy Markdown

Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax commented Jun 13, 2016

Copy link

Copy Markdown

Member Author

Landed in 0c73c9f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax closed this

Jun 13, 2016

addaleax added a commit that referenced this pull request

Jun 13, 2016


          src: fix --without-inspector build

0c73c9f

`use_inspector` is not available if `HAVE_INSPECTOR` is false.
Before this commit, one usage of it would show up as an undeclared
identifier (introduced in a766ebf).

PR-URL: #7258
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>

addaleax deleted the fix-without-inspector-build branch

June 13, 2016 15:04

MylesBorins added this to the 7.0.0 milestone

Jun 14, 2016

MylesBorins mentioned this pull request

Jun 14, 2016

Track backport of v8_inspector nodejs/Release#109

Closed

MylesBorins added the dont-land-on-v6.x label

Jun 14, 2016

Fishrock123 removed the dont-land-on-v6.x label

Jul 5, 2016

Fishrock123 pushed a commit that referenced this pull request

Jul 5, 2016


          src: fix --without-inspector build

38d36e3

`use_inspector` is not available if `HAVE_INSPECTOR` is false.
Before this commit, one usage of it would show up as an undeclared
identifier (introduced in a766ebf).

PR-URL: #7258
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>

Fishrock123 mentioned this pull request

Jul 5, 2016

Propose v6.3.0 (v2) #7550

Merged

MylesBorins mentioned this pull request

Jul 11, 2016

Audit commits not found on v4.x-staging #7661

Closed

MylesBorins added the dont-land-on-v4.x label

Jul 11, 2016

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

inspector

Issues and PRs related to the V8 inspector protocol.

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.