GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update build instructions for Windows by joaocgreis · Pull Request #7285 · nodejs/node

Conversation

@joaocgreis

@joaocgreis joaocgreis commented Jun 13, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions.

Corrected the test command to run on Windows after compiling.

cc @nodejs/platform-windows

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joaocgreis
doc: update build instructions for Windows
7dda497 
The Visual C++ Build Tools are supported to build Node on Windows and
already used in CI, so they should be included in the build
instructions.
@joaocgreis joaocgreis added doc Issues and PRs related to Node.js documentation. windows Issues and PRs related to the Windows platform. lts-watch-v4.x labels Jun 13, 2016
rvagg
rvagg reviewed Jun 13, 2016
View reviewed changes
Comment thread BUILDING.md Outdated
```
$ node -e "console.log('Hello from Node.js ' + process.version)"
```text
> Release\node -e "console.log('Hello from Node.js ' + process.version)"

@rvagg rvagg Jun 13, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to update this, either console.log(Hello from Node.js ${process.version}) or console.log('Hello from Node.js', process.version)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rvagg

rvagg commented Jun 13, 2016

Copy link
Copy Markdown
Member

lgtm sans suggestions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Jun 13, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis
fixup
f650c22
@joaocgreis

joaocgreis commented Jun 13, 2016

Copy link
Copy Markdown
Member Author

Updated, will land in two days if there are no objections (this is straightforward but not urgent).

@rvagg Used the second option for the console.log because it also works in PoweShell and it's only needed to change the slash for Git Bash.

Thanks for the reviews!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joshgav

joshgav commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

/cc @AndrewPardoe @mousetraps
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis

joaocgreis commented Jun 17, 2016

Copy link
Copy Markdown
Member Author

@joshgav @AndrewPardoe @mousetraps let me know if you have any remarks, or want more time to review and discuss. If not, I'll land this next week. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndrewPardoe

AndrewPardoe commented Jun 18, 2016

Copy link
Copy Markdown

LGTM, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joaocgreis added a commit that referenced this pull request Jun 23, 2016
@joaocgreis
doc: update build instructions for Windows
0a8f5a0 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
@joaocgreis

joaocgreis commented Jun 23, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3062/

Landed in 0a8f5a0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis joaocgreis closed this Jun 23, 2016
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@joaocgreis @Fishrock123
doc: update build instructions for Windows
924e4f8 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Propose v6.3.0 #7441
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@joaocgreis @Fishrock123
doc: update build instructions for Windows
029af2c 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Propose v6.3.0 (v2) #7550
Merged
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jul 11, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@joaocgreis Myles Borins
doc: update build instructions for Windows
04ac87e 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@joaocgreis @MylesBorins
doc: update build instructions for Windows
40ef0f6 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@joaocgreis Myles Borins
doc: update build instructions for Windows
39102f9 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
v4.5.0 proposal #7688
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@joaocgreis Myles Borins
doc: update build instructions for Windows
e4007cb 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@joaocgreis Myles Borins
doc: update build instructions for Windows
0a85987 
The Visual C++ Build Tools are supported to build Node on Windows
and already used in CI, so they should be included in the build
instructions.

Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joaocgreis @rvagg @cjihrig @joshgav @AndrewPardoe @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.