GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repl: tab completion for defined commands by princejwesley · Pull Request #7364 · nodejs/node

Conversation

@princejwesley

@princejwesley princejwesley commented Jun 22, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

Tab completion is not working for REPL defined commands

> .<<TAB>>
break  clear  exit   help   load   save

>.b<<TAB>>  // no tab completion

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@princejwesley
repl: tab completion for defined commands
b680072
@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Jun 22, 2016
@Fishrock123 Fishrock123 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 24, 2016
@Fishrock123

Fishrock123 commented Jun 24, 2016

Copy link
Copy Markdown
Contributor

LGTM, CI: https://ci.nodejs.org/job/node-test-pull-request/3065/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123 Fishrock123 self-assigned this Jun 24, 2016
@addaleax

addaleax commented Jun 25, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123 Fishrock123 removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 27, 2016
@Fishrock123

Fishrock123 commented Jun 27, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks, landed in 9d56c40!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123 Fishrock123 closed this Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@princejwesley @Fishrock123
repl: fix tab completion for defined commands
9d56c40 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@princejwesley @Fishrock123
repl: fix tab completion for defined commands
e4db716 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Propose v6.3.0 #7441
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@princejwesley @Fishrock123
repl: fix tab completion for defined commands
ca95a84 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Propose v6.3.0 (v2) #7550
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Audit commits not found on v4.x-staging #7661
Closed
@MylesBorins MylesBorins added the land-on-v4.x label Jul 11, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@princejwesley Myles Borins
repl: fix tab completion for defined commands
d8c9f4c 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@princejwesley @MylesBorins
repl: fix tab completion for defined commands
73cdc54 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@princejwesley Myles Borins
repl: fix tab completion for defined commands
e9585d2 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@princejwesley Myles Borins
repl: fix tab completion for defined commands
7fd1f1a 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
v4.5.0 proposal #7688
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@princejwesley Myles Borins
repl: fix tab completion for defined commands
e626c3c 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@princejwesley Myles Borins
repl: fix tab completion for defined commands
c8e9adb 
PR-URL: #7364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Fishrock123 Fishrock123

Labels

repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@princejwesley @Fishrock123 @addaleax @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.