GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "child_process: measure buffer length in bytes" by Trott · Pull Request #7377 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jun 22, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
Affected core subsystem(s)

child_process

Description of change

This needs #7375 to land first.

Refs: #7342

The commit being reverted fixed a bug but accidentally introduced a breaking change. This reverts it. The change should be re-proposed as semver-major.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott added the child_process Issues and PRs related to the child_process subsystem. label Jun 22, 2016
@Trott Trott changed the title Revertomatic Revert "child_process: measure buffer length in bytes" Jun 22, 2016
@Trott Trott mentioned this pull request Jun 23, 2016
child_process: measure buffer length in bytes #7381
Closed
3 of 4 tasks
@Trott Trott added the wip Issues and PRs that are still a work in progress. label Jun 23, 2016
Trott added 2 commits June 23, 2016 10:33
@Trott
test: add test for exec() known issue
c4a7f57 
Refs: nodejs#7342
@Trott
Revert "child_process: measure buffer length in bytes"
c69d51e 
This reverts commit c9a5990.
@Trott
Trott force-pushed the revertomatic branch from 194ad6f to c69d51e Compare June 23, 2016 17:33
@rvagg

rvagg commented Jun 27, 2016

Copy link
Copy Markdown
Member

lgtm, I'm always up for a revert and new tests!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Jun 27, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 27, 2016

Copy link
Copy Markdown
Member Author

Leaving this as in-progress because I don't want it to land until we've figured out if the correct path forward is #7381 or #7391. For the record, I favor #7391, but could live with either.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 30, 2016

Copy link
Copy Markdown
Member Author

Closing. Revert was done as part of #7391
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Jun 30, 2016
@Trott
Trott deleted the revertomatic branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Trott @rvagg @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.