GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add lance to collaborators. by lance · Pull Request #7407 · nodejs/node

Conversation

@lance

@lance lance commented Jun 24, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add @lance to collaborator list on README.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lance
doc: add lance to collaborators.
a671dd7
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jun 24, 2016
@Trott

Trott commented Jun 24, 2016

Copy link
Copy Markdown
Member

Nit: no period at the end of the first commit line
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Jun 24, 2016

Copy link
Copy Markdown
Member

LGTM with @Trott’s nit, welcome!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 24, 2016

Copy link
Copy Markdown
Member

LGTM with a nit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Jun 24, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lance added a commit that referenced this pull request Jun 24, 2016
@lance
doc: add lance to collaborators
0b9e135 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
@lance

lance commented Jun 24, 2016

Copy link
Copy Markdown
Member Author

Landed in 0b9e135
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lance lance closed this Jun 24, 2016
@lance
lance deleted the add-lance-to-readme branch June 24, 2016 17:31
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@lance @Fishrock123
doc: add lance to collaborators
c4d3580 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Propose v6.3.0 #7441
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@lance @Fishrock123
doc: add lance to collaborators
4486ba9 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Propose v6.3.0 (v2) #7550
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Audit commits not found on v4.x-staging #7661
Closed
@MylesBorins MylesBorins added the land-on-v4.x label Jul 11, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@lance Myles Borins
doc: add lance to collaborators
f495705 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@lance @MylesBorins
doc: add lance to collaborators
1d4a4b2 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@lance Myles Borins
doc: add lance to collaborators
c66170b 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@lance Myles Borins
doc: add lance to collaborators
19e5d2a 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
v4.5.0 proposal #7688
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@lance Myles Borins
doc: add lance to collaborators
23c26a3 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@lance Myles Borins
doc: add lance to collaborators
13d60ca 
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@lance @Trott @addaleax @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.