GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: drop unconditional openssl dep from cctest by bnoordhuis · Pull Request #7486 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Jun 29, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't link in openssl when building ./configure --without-inspector,
it's only used by the inspector cctests. Ditto libuv and http_parser.

Fixes: #7478

CI: https://ci.nodejs.org/job/node-test-pull-request/3131/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnoordhuis bnoordhuis added build Issues and PRs related to Node.js builds or CI infrastructure. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jun 29, 2016
@bnoordhuis bnoordhuis mentioned this pull request Jun 29, 2016
build: --shared-openssl still builds openssl #7478
Closed
@MylesBorins

MylesBorins commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

LGTM if CI is green. Do we skip the cc tests in that case?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Jun 29, 2016

Copy link
Copy Markdown
Member Author

No, just the inspector cctests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

That's what I meant to ask 😄

Thanks for the clarification
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

LGTM pending CI
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the openssl Issues and PRs related to the OpenSSL dependency. label Jun 29, 2016
@jasnell

jasnell commented Jun 29, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis
build: drop unconditional openssl dep from cctest
7dcc4af 
Don't link in openssl when building `./configure --without-inspector`,
it's only used by the inspector cctests.  Ditto libuv and http_parser.

Fixes unnecessarily building openssl when `--shared-openssl` is also
passed to configure.

Fixes: nodejs#7478
PR-URL: nodejs#7486
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis
bnoordhuis force-pushed the fix7478 branch from 1d59621 to 7dcc4af Compare June 30, 2016 11:33
@bnoordhuis bnoordhuis closed this Jun 30, 2016
@bnoordhuis
bnoordhuis deleted the fix7478 branch June 30, 2016 11:33
@bnoordhuis
bnoordhuis merged commit 7dcc4af into nodejs:master Jun 30, 2016
@bnoordhuis

bnoordhuis commented Jun 30, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd Apologies, I forgot to add you as a reviewer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ChALkeR

ChALkeR commented Jun 30, 2016

Copy link
Copy Markdown
Member

Yes, thanks, that works with fixing it when v8_inspector is disabled.

But what about the case when it's enabled, and --shared-openssl is also enabled? It still builds bundled openssl for some reason. Same for other deps.

Would wrapping all those deps inside ofv8_inspector condition in additional idividual conditions (like 841b434 does for openssl) break anything?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Jun 30, 2016

Copy link
Copy Markdown
Member Author

Virtual shrug. Of course it could be made to work but since --shared-openssl is primarily intended for embedders, I don't really care much because I doubt they would care much.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Jun 30, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis nbd. I've started using https://github.com/evanlucas/core-get-reviewers to simplify things for myself, might be worth checking out. 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@bnoordhuis @Fishrock123
build: drop unconditional openssl dep from cctest
1bd6a62 
Don't link in openssl when building `./configure --without-inspector`,
it's only used by the inspector cctests.  Ditto libuv and http_parser.

Fixes unnecessarily building openssl when `--shared-openssl` is also
passed to configure.

Fixes: #7478
PR-URL: #7486
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Propose v6.3.0 (v2) #7550
Merged
This was referenced Jul 6, 2016
build: respect --shared-* flags for inspector deps #7569
Merged
Fails to build with --shared-openssl configure option #7583
Closed
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Audit commits not found on v4.x-staging #7661
Closed
@MylesBorins MylesBorins added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol. labels Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. inspector Issues and PRs related to the V8 inspector protocol. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@bnoordhuis @MylesBorins @cjihrig @jasnell @ChALkeR @mscdex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.