GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: Fix compile failure in backtrace_posix.cc by mhdawson · Pull Request #7544 · nodejs/node

Conversation

mhdawson commented Jul 5, 2016

Copy link

Copy Markdown

Member

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

core

Description of change

Fix compile failure in backtrace_posix.c on AIX introduced by #6734

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          build: Fix compile failure in backtrace_posix.cc

ee3ed0f

Fix compile failure in backtrace_posix.c on AIX

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label

Jul 5, 2016

mhdawson mentioned this pull request

Jul 5, 2016

backtrace_posix.cc fails to compile on AIX #7539

Closed

mhdawson commented Jul 5, 2016

Copy link

Copy Markdown

Member Author

@bnoordhuis

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson commented Jul 5, 2016

Copy link

Copy Markdown

Member Author

CI run https://ci.nodejs.org/job/node-test-pull-request/3181/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cjihrig commented Jul 5, 2016

Copy link

Copy Markdown

Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson commented Jul 5, 2016

Copy link

Copy Markdown

Member Author

Going to land this once the CI run completes since it fixes a build break and the change is small and have one LGTM altready.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis commented Jul 5, 2016

Copy link

Copy Markdown

Member

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

mscdex commented Jul 5, 2016

Copy link

Copy Markdown

Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson commented Jul 5, 2016

Copy link

Copy Markdown

Member Author

CI is good landing

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson commented Jul 5, 2016

Copy link

Copy Markdown

Member Author

Landed as 95a3c8f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson added a commit that referenced this pull request

Jul 5, 2016


          build: Fix compile failure in backtrace_posix.cc

95a3c8f

Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Brian White <[email protected]>

mhdawson closed this

Jul 5, 2016

Fishrock123 pushed a commit that referenced this pull request

Jul 6, 2016


          build: Fix compile failure in backtrace_posix.cc

5e4113e

Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Brian White <[email protected]>

Fishrock123 mentioned this pull request

Jul 6, 2016

Propose v6.3.0 (v2) #7550

Merged

MylesBorins mentioned this pull request

Jul 11, 2016

Audit commits not found on v4.x-staging #7661

Closed

MylesBorins added the lts-watch-v4.x label

Jul 12, 2016

MylesBorins commented Jul 12, 2016

Copy link

Copy Markdown

Contributor

@mhdawson lts?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins mentioned this pull request

Jul 14, 2016

src: print backtrace on fatal error #6734

Merged

MylesBorins commented Jul 14, 2016

Copy link

Copy Markdown

Contributor

needs to be backported if #6734 is backported

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson deleted the aixstack branch

March 15, 2017 21:56

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.