GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-net-write-slow by Trott · Pull Request #7555 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

Description of change

Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: fix flaky test-net-write-slow
b685efc 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: nodejs#7516
@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. freebsd Issues and PRs related to the FreeBSD platform. labels Jul 6, 2016
@Trott

Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

(Still kind of wonder if the test shouldn't be removed, though. See #7516 for archeological and other details.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3189/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

CI is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

@nodejs/testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

What about changing the timeout value based on os.platform() or something?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax mentioned this pull request Jul 6, 2016
Propose v6.3.0 (v2) #7550
Merged
@Trott

Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

@mscdex That's an option, but I don't think it's preferable in this situation. The arbitrarily large value doesn't make the test take any longer to pass. If it affected the test duration, I'd be inclined to tune the value based on platform. But since it doesn't affect execution time on successful tests, I'd prefer to avoid the complexity of different values on different platforms.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott mentioned this pull request Jul 6, 2016
repl: added support for custom completions. #7527
Closed
4 tasks done
@Trott

Trott commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

This FreeBSD failure on CI is starting to get a little out of control, so I'm going to try to raise the profile of this fix and argue for an expedited landing (small change, big positive impact, easy to revert, doesn't affect userland code). Raising profile: @nodejs/collaborators
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina

mcollina commented Jul 6, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott mentioned this pull request Jul 7, 2016
test: fix flaky test/fs-read-buffer-tostring-fail #7575
Closed
3 tasks done
@santigimeno

santigimeno commented Jul 7, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit to Trott/io.js that referenced this pull request Jul 7, 2016
@Trott
test: fix flaky test-net-write-slow
9d654a3 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: nodejs#7516
PR-URL: nodejs#7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott

Trott commented Jul 7, 2016

Copy link
Copy Markdown
Member Author

Landed in 9d654a3. Goodbye, red FreeBSD CI.
addaleax reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Jul 7, 2016
@ChALkeR ChALkeR mentioned this pull request Jul 9, 2016
build: respect --shared-* flags for inspector deps #7569
Merged
2 tasks done
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Audit commits not found on v4.x-staging #7661
Closed
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott Myles Borins
test: fix flaky test-net-write-slow
57de61f 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins added the land-on-v4.x label Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott @MylesBorins
test: fix flaky test-net-write-slow
db020b4 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott Myles Borins
test: fix flaky test-net-write-slow
a037e5e 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott Myles Borins
test: fix flaky test-net-write-slow
9dcc1ea 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
v4.5.0 proposal #7688
Merged
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
@Trott @evanlucas
test: fix flaky test-net-write-slow
9716729 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott Myles Borins
test: fix flaky test-net-write-slow
df5a82b 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott Myles Borins
test: fix flaky test-net-write-slow
db35efa 
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@evanlucas evanlucas mentioned this pull request Jul 18, 2016
v6.3.1 Release Proposal #7782
Merged
@Trott
Trott deleted the slowrite branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

freebsd Issues and PRs related to the FreeBSD platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @mscdex @mcollina @santigimeno @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.