GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — internal: changed var to const in linkedlist by AdriVanHoudt · Pull Request #8609 · nodejs/node

Conversation

@AdriVanHoudt

@AdriVanHoudt AdriVanHoudt commented Sep 17, 2016 •
edited by Fishrock123
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

internal

Description of change

Changed var to const.
Part of nodejs/code-and-learn#56

Refs: #8410

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AdriVanHoudt
internal: changed var to const in linkedlist
e129f26
@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout(). label Sep 17, 2016
@targos

targos commented Sep 17, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mscdex

mscdex commented Sep 17, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This may sound a bit crazy, but we may want to benchmark this change. I noticed not too long ago that var => const was actually causing slowdowns and timers are definitely a hot path. I do not know if this has changed with V8 5.4 or not though.
vkurchatkin, Fishrock123, and mcollina reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdriVanHoudt

AdriVanHoudt commented Sep 17, 2016

Copy link
Copy Markdown
Contributor Author

@mscdex if there is anything I can help with let me know. I do not know how to run benchmarks atm so yeah :P
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123 Fishrock123 mentioned this pull request Sep 17, 2016
Benchmark var -> const before merging mass rewrites #8637
Closed
@mscdex

mscdex commented Sep 19, 2016

Copy link
Copy Markdown
Contributor

Ok as far as I can tell, this particular change does not seem to have any measurable negative performance impact, so it should be fine to land.

On another positive note, I think I managed to improve setImmediate() performance while I was digging in the code.
billouboq and AdriVanHoudt reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Sep 20, 2016
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell

jasnell commented Sep 20, 2016

Copy link
Copy Markdown
Member

@AdriVanHoudt ... now that you have a few of these type of PRs in, one thing that would likely be helpful would be to batch multiple commits either into a single PR or even single commit. Doing so makes review a bit easier.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Sep 20, 2016

Copy link
Copy Markdown
Contributor

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdriVanHoudt

AdriVanHoudt commented Sep 20, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell yeah during the summit the task got divided pretty much by file that's why. Also some changes do entail a lot more (like perf stuff) then I thought so the splitting kinda helped there. I will definitely do more in 1 commit next time! (or do you want me to merge all these together?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Sep 20, 2016

Copy link
Copy Markdown
Member

nah, go ahead and leave these as is. Just wanted to make the suggestion for the future! :-)
AdriVanHoudt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Sep 20, 2016

Copy link
Copy Markdown
Member

tbh, I’d still prefer 1 commit per file, if only because that may make backporting easier.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Sep 20, 2016

Copy link
Copy Markdown
Member

ok, yeah, makes sense. At the very least tho, multiple similar commits per PR.
AdriVanHoudt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:10
@jasnell

jasnell commented Sep 22, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4218/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@imyller

imyller commented Oct 3, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4372/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdriVanHoudt

AdriVanHoudt commented Oct 4, 2016

Copy link
Copy Markdown
Contributor Author

Jenkins is kinda hard to navigate so not sure what is failing :S
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Oct 5, 2016

Copy link
Copy Markdown
Member

… Yeah.

New CI, given that #8924 has fixed some of the failures: https://ci.nodejs.org/job/node-test-commit/5455/
AdriVanHoudt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell self-assigned this Oct 6, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@AdriVanHoudt @jasnell
lib: changed var to const in linkedlist
b2534f1 
PR-URL: #8609
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@jasnell

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

Landed in b2534f1
AdriVanHoudt reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 6, 2016
@AdriVanHoudt
AdriVanHoudt deleted the const_linkedlist branch October 7, 2016 08:03
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@AdriVanHoudt @jasnell
lib: changed var to const in linkedlist
9578038 
PR-URL: #8609
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@AdriVanHoudt @Fishrock123
lib: changed var to const in linkedlist
313a45d 
PR-URL: #8609
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@AdriVanHoudt Myles Borins
lib: changed var to const in linkedlist
3b448a7 
PR-URL: #8609
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins added the land-on-v4.x label Nov 22, 2016
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
v4.7.0 proposal #9736
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jasnell jasnell

Labels

timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@AdriVanHoudt @targos @mscdex @jasnell @addaleax @imyller @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.