GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — win,msi: mark INSTALLDIR property as secure by joaocgreis · Pull Request #8795 · nodejs/node

Conversation

@joaocgreis

@joaocgreis joaocgreis commented Sep 26, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Windows, MSI.

Description of change

When installing with Always install with elevated privileges policy set on Windows, MSIExec will spawn an installation process with elevated privileges, but will only be able to pass secure properties to it. Without this change, INSTALLDIR could not be passed and would revert to the default, effectively ignoring any change in the installation directory made by the user.

This marks INSTALLDIR as secure, allowing it to be passed to the server MSIExec process during installation.

Tested on Windows 7 with the policy set, with the MSI and INSTALLDIR in two different non-C hard drives (showing that other properties get their values corretly). Also tested upgrade from released Node 6.4 to this on Windows 10.

Fixes: #6057

cc @nodejs/platform-windows

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joaocgreis
win,msi: mark INSTALLDIR property as secure
c01a163 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

Fixes: nodejs#6057
@joaocgreis joaocgreis added windows Issues and PRs related to the Windows platform. install Issues and PRs related to installing Node.js and its installers. lts-watch-v4.x labels Sep 26, 2016
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 26, 2016
@joaocgreis

joaocgreis commented Sep 26, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/4292/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Sep 26, 2016

Copy link
Copy Markdown
Member

LGTM - this change sounds reasonable. For those who want a reference http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Sep 27, 2016
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasongin

jasongin commented Sep 27, 2016

Copy link
Copy Markdown
Member

:shipit:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 7, 2016

Copy link
Copy Markdown
Member

@nodejs/build ... does this LGTY?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis

joaocgreis commented Oct 7, 2016

Copy link
Copy Markdown
Member Author

@jasnell sorry, I left this one too long. I take the reviews above as enough to move forward here, I'll land this early next week if there are no objections (or feel free to if you want to land). Thanks for the ping!
jasnell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis

joaocgreis commented Oct 10, 2016

Copy link
Copy Markdown
Member Author

Landed in 4896f0f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joaocgreis joaocgreis closed this Oct 10, 2016
joaocgreis added a commit that referenced this pull request Oct 10, 2016
@joaocgreis
win,msi: mark INSTALLDIR property as secure
4896f0f 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@joaocgreis @jasnell
win,msi: mark INSTALLDIR property as secure
58550fd 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@joaocgreis @Fishrock123
win,msi: mark INSTALLDIR property as secure
b83f51a 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@joaocgreis Myles Borins
win,msi: mark INSTALLDIR property as secure
bdb6cf9 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Nov 18, 2016
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
v4.7.0 proposal #9736
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

install Issues and PRs related to installing Node.js and its installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joaocgreis @benjamingr @jasongin @jasnell @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.