GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: don't build icu with -fno-rtti by bnoordhuis · Pull Request #8886 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Oct 1, 2016

Copy link
Copy Markdown
Member

ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnoordhuis
build: don't build icu with -fno-rtti
dae4771 
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: nodejs#8867
@bnoordhuis bnoordhuis added build Issues and PRs related to Node.js builds or CI infrastructure. i18n-api Issues and PRs related to Node.js internationalization support. labels Oct 1, 2016
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 1, 2016
@bnoordhuis bnoordhuis mentioned this pull request Oct 1, 2016
Cannot Build Node.js 6.7.0 on CorePure64 Tinycore Linux #8867
Closed
@mscdex mscdex removed the tools Issues and PRs related to the tools directory. label Oct 1, 2016
jbergstroem
jbergstroem approved these changes Oct 1, 2016
View reviewed changes

@jbergstroem jbergstroem left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fhinkel
fhinkel approved these changes Oct 3, 2016
View reviewed changes
@fhinkel

fhinkel commented Oct 3, 2016

Copy link
Copy Markdown
Contributor

Landed in c1be609.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fhinkel fhinkel closed this Oct 3, 2016
fhinkel pushed a commit that referenced this pull request Oct 3, 2016
@bnoordhuis @fhinkel
build: don't build icu with -fno-rtti
c1be609 
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867
PR-URL: #8886
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@bnoordhuis @jasnell
build: don't build icu with -fno-rtti
d98ae6a 
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867
PR-URL: #8886
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins added the lts-watch-v4.x label Oct 6, 2016
@MylesBorins

MylesBorins commented Oct 6, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis should this be backported or is it specific to v6?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Oct 7, 2016

Copy link
Copy Markdown
Member Author

Looking at tools/icu/icu-generic.gyp in the v4.x-staging branch, this would need to be back-ported, yes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis bnoordhuis mentioned this pull request Oct 7, 2016
nodejs Linux clang libc++ no joy? #8973
Closed
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@bnoordhuis @Fishrock123
build: don't build icu with -fno-rtti
a202be6 
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867
PR-URL: #8886
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@bnoordhuis Myles Borins
build: don't build icu with -fno-rtti
3919edb 
ICU should be compiled with -frtti (and it sets that flag in its gyp
file) but it was also inheriting the -fno-rtti flag from common.gypi,
breaking the build on some systems.

Fixes: #8867
PR-URL: #8886
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Nov 18, 2016
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
v4.7.0 proposal #9736
Merged
@gibfahn gibfahn mentioned this pull request Aug 23, 2017
_ZNKSt9type_infoeqERKS_ not found with gcc 6.3.0.1 on AIX 7.1 #14785
Closed
srl295
srl295 reviewed Aug 30, 2017
View reviewed changes

@srl295 srl295 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the fact 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 left review comments
+2 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@jbergstroem jbergstroem jbergstroem approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. i18n-api Issues and PRs related to Node.js internationalization support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@bnoordhuis @fhinkel @MylesBorins @jbergstroem @srl295 @mscdex @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.