GeezerVison

I made that change intentionally. Why would you want a different output format locally?

Can we leave the tap output for make test-ci and use the pretty one locally? There's not really a reason to have tap output in the local tests.

I think consistency with the CI is a pretty good reason. Libuv does the same thing; it makes visually comparing the output of local and remote runs a lot easier.

If you want CI output, just run make test-ci -- we aren't the same as Libuv. Do you want to change the JS test output too? If not, this should be reverted for local tests.

You asked for a reason and I gave you one. You are welcome to disagree but at least try to come up with a counterargument.

It's harder to read and also inconsistent.

Readability is subjective but I agree it's inconsistent. Then again, so is the normal gtest output vis-a-vis the JS test runner and the linters. It doesn't bother me personally but I'm okay with switching to TAP wholesale if you think consistency is important.

I'm not ok with that as it would mean scrolling through a few thousand lines of terminal text to find an error.

If you really want it, we can make make test-tap. It is far easier to do that than update all the docs references to point to some new make test-pretty for everyone new coming here.

fwiw, I'm partial to the new formatting but will go with whatever the majority opinion is here. Perhaps rather than simply revert, this PR could add a test-tap target for those of us who prefer it.

@jasnell Are you saying test-tap would output TAP just for cctest but use progress indicators/"pretty print" for all other tests (like it is before this PR), or?

@mscdex... For now, test-tap would use the current behavior (before this revert). Eventually I'd like to see test-tap do the full output as TAP.

Ok, I've added test-tap that uses a new flag to configure the default printed result format.

CI again: https://ci.nodejs.org/job/node-test-pull-request/4410/

It'd be really useful to have both TAP and pretty formats available for running tests, I frequently find myself using both.

Is it possible to have the gtest pretty format match the tools/test.py pretty format? Ideally you'd just have the one line for everything (assuming no failures).

@bnoordhuis Is this acceptable to you (make test-tap)?

If the choice is between no TAP output locally or carrying more patches on top of gtest, I'd rather go with the former.

@jbergstroem Did you ever make the change to make the CI pick up cctest.tap? Looking at e.g. https://ci.nodejs.org/job/node-test-commit-linux/5713/nodes=centos5-32/console I get the impression it doesn't currently.

@bnoordhuis no, let me fix that now. Just very tedious working with jenkins jobs when its slow :'(

@bnoordhuis just did a test run with aix61. Looks good -- do you agree? https://ci.nodejs.org/job/node-test-commit-aix/1508/

@jbergstroem Yes, looks good, thanks.

@bnoordhuis cool. Will roll out the change now.

CI once more before landing: https://ci.nodejs.org/job/node-test-pull-request/4626/

EDIT: CI is green except for a few flaky tests on freebsd and pi1.