GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — util: use template literals by a0viedo · Pull Request #9120 · nodejs/node

Conversation

@a0viedo

@a0viedo a0viedo commented Oct 16, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Util

Description of change

This commit changes string manipulation in favor of template literals in the util module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Oct 16, 2016
@mscdex

mscdex commented Oct 16, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/4533/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a0viedo

a0viedo commented Oct 16, 2016

Copy link
Copy Markdown
Member Author

oh the linter was failing for a long line, gonna make that fix once CI finishes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas

evanlucas commented Oct 17, 2016

Copy link
Copy Markdown
Contributor

I'd be curious to see if this causes any performance regressions in util.format/util.inspect
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Oct 17, 2016

Copy link
Copy Markdown
Member

There should be no change in performance. AFAIK untagged template literals are desugared to string concatenation by V8's parser.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 17, 2016
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@a0viedo
util: use template strings
e668a1a 
This commit changes string manipulation in favor of template literals in the `util` module.
@a0viedo

a0viedo commented Oct 17, 2016

Copy link
Copy Markdown
Member Author

Fixed linter.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg
rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@jasnell

jasnell commented Oct 19, 2016

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/4577/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Oct 19, 2016
View reviewed changes
lpinca
lpinca approved these changes Oct 24, 2016
View reviewed changes
@jasnell

jasnell commented Oct 24, 2016

Copy link
Copy Markdown
Member

New CI since the last one was aborted: https://ci.nodejs.org/job/node-test-pull-request/4637/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Oct 26, 2016
@a0viedo @jasnell
util: use template strings
1ee36f6 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell

jasnell commented Oct 26, 2016

Copy link
Copy Markdown
Member

Landed in 1ee36f6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 26, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@a0viedo @evanlucas
util: use template strings
4f0596f 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
v7.1.0 proposal - 2016-11-08 #9438
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@a0viedo Myles Borins
util: use template strings
52a04bb 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x labels Nov 22, 2016
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@a0viedo Myles Borins
util: use template strings
f18f3b6 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Nov 22, 2016
v6.9.2 proposal #9735
Merged
v4.7.0 proposal #9736
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@a0viedo @mscdex @evanlucas @targos @jasnell @lpinca @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.