GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: use wxneeded on openbsd by qbit · Pull Request #9232 · nodejs/node

Conversation

@qbit

@qbit qbit commented Oct 21, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@qbit
build: use wxneeded on openbsd
60eb674 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Oct 21, 2016
bnoordhuis
bnoordhuis approved these changes Oct 22, 2016
View reviewed changes
@bnoordhuis bnoordhuis added the lts-watch-v4.x label Oct 22, 2016
jasnell
jasnell approved these changes Oct 22, 2016
View reviewed changes
@qbit

qbit commented Oct 22, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis @jasnell would it be possible to get this: c-ares/c-ares#68 back ported to the cares dep?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Oct 23, 2016

Copy link
Copy Markdown
Member

If it landed upstream I'm fine with that. Do you want to add it to this pull request or do you want to file a new one?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jbergstroem
jbergstroem approved these changes Oct 23, 2016
View reviewed changes

@jbergstroem jbergstroem left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@qbit
deps: back port OpenBSD fix in c-ares/c-ares
64bf5f9 
PR-URL: c-ares/c-ares#68
@qbit

qbit commented Oct 23, 2016

Copy link
Copy Markdown
Contributor Author

Added the c-ares fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Oct 25, 2016
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/4668/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell

jasnell commented Oct 26, 2016

Copy link
Copy Markdown
Member

New CI because previous was partially canceled: https://ci.nodejs.org/job/node-test-pull-request/4691/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 28, 2016

Copy link
Copy Markdown
Member

Unrelated failure in CI. Will land this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell self-assigned this Oct 28, 2016
jasnell pushed a commit that referenced this pull request Oct 28, 2016
@qbit @jasnell
build: use wxneeded on openbsd
a0c6898 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 28, 2016
@qbit @jasnell
deps: back port OpenBSD fix in c-ares/c-ares
40fd696 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@jasnell

jasnell commented Oct 28, 2016

Copy link
Copy Markdown
Member

Landed in a0c6898...40fd696
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 28, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@qbit @evanlucas
build: use wxneeded on openbsd
f7d8481 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@qbit @evanlucas
deps: back port OpenBSD fix in c-ares/c-ares
0f871e1 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
v7.1.0 proposal - 2016-11-08 #9438
Merged
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@qbit Myles Borins
deps: back port OpenBSD fix in c-ares/c-ares
91fce10 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@qbit Myles Borins
deps: back port OpenBSD fix in c-ares/c-ares
8d2bc95 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Nov 18, 2016
@MylesBorins

MylesBorins commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

landed on v4 and v6. Please let me know if there are any issues
qbit reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@qbit @MylesBorins
deps: back port OpenBSD fix in c-ares/c-ares
f0a8bcc 
Original PR: c-ares/c-ares#68

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@qbit Myles Borins
build: use wxneeded on openbsd
59d821d 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@qbit Myles Borins
build: use wxneeded on openbsd
c857586 
On OpenBSD 6.0 and greater W^X is enabled by default. All executables
that violate W^X need to be marked with PT_OPENBSD_WXNEEDED. In
addition to this, they must be executed from a filesystem mounted with
'wxallowed'.

More info on W^X: https://en.wikipedia.org/wiki/W%5EX

PR-URL: #9232
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Nov 22, 2016
v6.9.2 proposal #9735
Merged
v4.7.0 proposal #9736
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
+1 more reviewer
@jbergstroem jbergstroem jbergstroem approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jasnell jasnell

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@qbit @bnoordhuis @jasnell @MylesBorins @jbergstroem @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.