GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip whatwg url parse tests when icu is missing by jasnell · Pull Request #9246 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Oct 23, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The WHATWG url parser relies on ICU's punycode implementation. A handful of the standard tests fail when ICU is not present because of the additional checks that are not implemented. For now, skip the parse tests if ICU is not present.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell jasnell added url Issues and PRs related to the legacy built-in url module. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 23, 2016
@jbergstroem

jbergstroem commented Oct 23, 2016

Copy link
Copy Markdown
Member

It looks like we're using different methods throughout the test suite to figure out whether we have Intl support. Can you perhaps create a common.hasIntl while at it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 23, 2016

Copy link
Copy Markdown
Member Author

good idea
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
jasnell force-pushed the fix-test-whatwg-url-parsing branch from 61a0186 to 3dcd9f3 Compare October 23, 2016 17:11
@jasnell

jasnell commented Oct 23, 2016

Copy link
Copy Markdown
Member Author

nointl specific CI: https://ci.nodejs.org/job/node-test-commit-linux-nointl/2/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis reviewed Oct 24, 2016
View reviewed changes
Comment thread test/common.js Outdated

@bnoordhuis bnoordhuis Oct 24, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other common.hasFoo properties are either simple data properties or getters, not functions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@jasnell jasnell Oct 24, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. switched to a getter

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell
test: add common.hasIntl
f4ce7c1
@jasnell
jasnell force-pushed the fix-test-whatwg-url-parsing branch from 3dcd9f3 to 3f871c1 Compare October 24, 2016 12:50
mhdawson
mhdawson approved these changes Oct 24, 2016
View reviewed changes
silverwind
silverwind approved these changes Oct 24, 2016
View reviewed changes

@silverwind silverwind left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/parallel/test-whatwg-url-parsing.js Outdated

@silverwind silverwind Oct 24, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intl

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/parallel/test-whatwg-url-setters.js Outdated

@silverwind silverwind Oct 24, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intl

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell
test: skip whatwg url parse and setter tests when icu is missing
99cd46d 
the WHATWG url parser relies on ICU's punycode implementation.
A handful of the standard tests fail when ICU is not present
because of the additional checks that are not implemented. For
now, skip the parse and setter tests if ICU is not present.
@jasnell
jasnell force-pushed the fix-test-whatwg-url-parsing branch from 3f871c1 to 99cd46d Compare October 24, 2016 15:53
@jasnell

jasnell commented Oct 24, 2016

Copy link
Copy Markdown
Member Author

Regular CI: https://ci.nodejs.org/job/node-test-pull-request/4641/
--without-intl CI: https://ci.nodejs.org/job/node-test-commit-linux-nointl/5/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 24, 2016

Copy link
Copy Markdown
Member Author

Unrelated failures in CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jbergstroem
jbergstroem approved these changes Oct 24, 2016
View reviewed changes

@jbergstroem jbergstroem left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnoordhuis
bnoordhuis approved these changes Oct 24, 2016
View reviewed changes
@bnoordhuis

bnoordhuis commented Oct 24, 2016

Copy link
Copy Markdown
Member

Apropos the WHATWG URL tests, would it be possible to add a 'needs intl' heuristic? Something like /[^\u0000-\u007F]/.test(test.input)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 24, 2016

Copy link
Copy Markdown
Member Author

Yeah, I was considering adding a check but making it more explicit by adding metadata to the test fixture to say whether or not ICU is required for that item. Takes the guess work out of it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 24, 2016

Copy link
Copy Markdown
Member Author

that said, this commit is intended primarily to make sure the non-intl CI is running green until I can get that done. Since the new URL parser is an experimental feature still, it shouldn't be holding things up
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Oct 25, 2016
@jasnell
test: add common.hasIntl
d7e4ae1 
PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
jasnell added a commit that referenced this pull request Oct 25, 2016
@jasnell
test: skip whatwg url parse and setter tests when icu is missing
52670fc 
the WHATWG url parser relies on ICU's punycode implementation.
A handful of the standard tests fail when ICU is not present
because of the additional checks that are not implemented. For
now, skip the parse and setter tests if ICU is not present.

PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@jasnell

jasnell commented Oct 25, 2016

Copy link
Copy Markdown
Member Author

Landed in d7e4ae1...52670fc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 25, 2016
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
@jasnell @evanlucas
test: add common.hasIntl
a39b98e 
PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
@jasnell @evanlucas
test: skip whatwg url parse and setter tests when icu is missing
5e138fe 
the WHATWG url parser relies on ICU's punycode implementation.
A handful of the standard tests fail when ICU is not present
because of the additional checks that are not implemented. For
now, skip the parse and setter tests if ICU is not present.

PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
v7.1.0 proposal - 2016-11-08 #9438
Merged
@MylesBorins MylesBorins added dont-land-on-v4.x labels Nov 18, 2016
TimothyGu pushed a commit to TimothyGu/node that referenced this pull request Nov 28, 2017
@jasnell @TimothyGu
test: add common.hasIntl
eba99fe 
PR-URL: nodejs#9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@TimothyGu TimothyGu mentioned this pull request Nov 28, 2017
Backport WHATWG URL to 6.x #17365
Closed
4 tasks done
MylesBorins pushed a commit that referenced this pull request Jan 18, 2018
@jasnell @MylesBorins
test: add common.hasIntl
df835c4 
Backport-PR-URL: #17365
PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
v6.13.0 proposal #18342
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@jasnell @MylesBorins
test: add common.hasIntl
b13268d 
Backport-PR-URL: #17365
PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@jasnell @MylesBorins
test: add common.hasIntl
9444883 
Backport-PR-URL: #17365
PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@jasnell @MylesBorins
test: add common.hasIntl
699c663 
Backport-PR-URL: #17365
PR-URL: #9246
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
+3 more reviewers
@silverwind silverwind silverwind approved these changes
@jbergstroem jbergstroem jbergstroem approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jasnell @jbergstroem @bnoordhuis @silverwind @mhdawson @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.