GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: remove dangling eslint symlink by sam-github · Pull Request #9299 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Oct 26, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

@Trott

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 26, 2016
@sam-github sam-github added tools Issues and PRs related to the tools directory. and removed tools Issues and PRs related to the tools directory. labels Oct 26, 2016
addaleax
addaleax approved these changes Oct 26, 2016
View reviewed changes
jasnell
jasnell approved these changes Oct 26, 2016
View reviewed changes
Trott
Trott approved these changes Oct 26, 2016
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure what the best way to keep this from happening going forward would be. I guess step one is just more awareness and people calling it out on PRs that update ESLint...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sam-github

sam-github commented Oct 26, 2016

Copy link
Copy Markdown
Contributor Author

@Trott I'm not sure either. How did you create the eslint you committed? What was your sequence? We could probably figure out one that works and document in a README somewhere. Or in the next commit message. You put some effort into your commit to say what you did, but just at a high level.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 26, 2016

Copy link
Copy Markdown
Member

btw, this one is trivial enough that it shouldn't need to wait the 48 hours to land.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Oct 26, 2016
View reviewed changes
@sam-github
tools: remove dangling eslint symlink
de24c45 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#9299
@sam-github
sam-github force-pushed the rm-eslint-invalid-symlinks branch from 928fb57 to de24c45 Compare October 27, 2016 16:35
@sam-github
sam-github merged commit de24c45 into nodejs:master Oct 27, 2016
@sam-github

sam-github commented Oct 27, 2016 •
edited by MylesBorins
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Landed in de24c45

(edited by @thealphanerd original message accidentally included the issue number not commit)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github
sam-github deleted the rm-eslint-invalid-symlinks branch October 27, 2016 16:39
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@sam-github @evanlucas
tools: remove dangling eslint symlink
c23ece7 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
v7.1.0 proposal - 2016-11-08 #9438
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
@sam-github Myles Borins
tools: remove dangling eslint symlink
1e6d788 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
@MylesBorins MylesBorins added land-on-v4.x labels Nov 17, 2016
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
@sam-github Myles Borins
tools: remove dangling eslint symlink
f9baa11 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@sam-github @MylesBorins
tools: remove dangling eslint symlink
07d34f9 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
This was referenced Nov 22, 2016
v6.9.2 proposal #9735
Merged
v4.7.0 proposal #9736
Merged
@sam-github sam-github mentioned this pull request Jan 12, 2017
Eslint fixes #10771
Closed
3 tasks done
sam-github added a commit that referenced this pull request Jan 12, 2017
@sam-github
eslint: remove dangling eslint symlink
0c8cfd4 
Reapplication of #9299 since the
symlink was re-added in f44969a.

PR-URL: #10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sam-github Italo A. Casas
eslint: remove dangling eslint symlink
870b45b 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@sam-github Italo A. Casas
eslint: remove dangling eslint symlink
9eb6d6b 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@sam-github sam-github mentioned this pull request Jan 27, 2017
v7.x backport: tools: update ESLint to current version #11009
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@sam-github @targos
eslint: remove dangling eslint symlink
ebd6f51 
Reapplication of #9299 since the
symlink was re-added in f44969a.

PR-URL: #10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sam-github Italo A. Casas
eslint: remove dangling eslint symlink
78a495e 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sam-github Italo A. Casas
eslint: remove dangling eslint symlink
ab144b0 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn gibfahn mentioned this pull request Apr 23, 2017
Document the eslint update process #12611
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@sam-github @jasnell @Trott @addaleax @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.