GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update minute-taking procedure for CTC by Trott · Pull Request #9425 · nodejs/node

Conversation

@Trott

@Trott Trott commented Nov 2, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The doc says that the CTC moderator is responsible for taking minutes
and that the minutes for each agenda item should be a separate pull
request.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves. Furthermore, it removes the separate-pull-request
requirement as that is not what happens in practice.

@nodejs/ctc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott added doc Issues and PRs related to Node.js documentation. ctc-review labels Nov 2, 2016
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 2, 2016
@joshgav

joshgav commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

LGTM, it's hard to run a meeting and take notes at the same time.

I didn't interpret the original as requiring a separate PR for each agenda item, but no matter with this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 4, 2016

Copy link
Copy Markdown
Member Author

I didn't interpret the original as requiring a separate PR

You're right. It probably was not intended that way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
evanlucas
evanlucas approved these changes Nov 4, 2016
View reviewed changes
mhdawson
mhdawson reviewed Nov 4, 2016
View reviewed changes
Comment thread GOVERNANCE.md Outdated

@mhdawson mhdawson Nov 4, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should insuring be ensuring instead ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gibfahn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
mhdawson
mhdawson approved these changes Nov 4, 2016
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott force-pushed the minutes branch from 9cad789 to 59c104a Compare November 5, 2016 04:40
@Trott
doc: update minute-taking procedure for CTC
d9044d1 
The doc says that the CTC moderator is responsible for taking minutes
and that the minutes for each agenda item should be a separate pull
request.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves. Furthermore, it removes the separate-pull-request
requirement as that is not what happens in practice.
@Trott
Trott force-pushed the minutes branch from 59c104a to d9044d1 Compare November 5, 2016 04:41
Trott added a commit to Trott/io.js that referenced this pull request Nov 6, 2016
@Trott
doc: update minute-taking procedure for CTC
7dd3fb8 
The doc says that the CTC moderator is responsible for taking minutes.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves.

PR-URL: nodejs#9425
Reviewed-By: Josh Gavant <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott

Trott commented Nov 6, 2016

Copy link
Copy Markdown
Member Author

Landed in 7dd3fb8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Nov 6, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@Trott @evanlucas
doc: update minute-taking procedure for CTC
4c4132e 
The doc says that the CTC moderator is responsible for taking minutes.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves.

PR-URL: #9425
Reviewed-By: Josh Gavant <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 7, 2016
v7.1.0 proposal - 2016-11-08 #9438
Merged
@Trott Trott removed the ctc-review label Nov 16, 2016
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@Trott Myles Borins
doc: update minute-taking procedure for CTC
d926f16 
The doc says that the CTC moderator is responsible for taking minutes.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves.

PR-URL: #9425
Reviewed-By: Josh Gavant <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@Trott Myles Borins
doc: update minute-taking procedure for CTC
d3c25c1 
The doc says that the CTC moderator is responsible for taking minutes.

This change updates the doc to say that the moderator is responsible for
making sure that notes are taken, but not necessarily taking the notes
themselves.

PR-URL: #9425
Reviewed-By: Josh Gavant <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x labels Nov 22, 2016
This was referenced Nov 22, 2016
v6.9.2 proposal #9735
Merged
v4.7.0 proposal #9736
Merged
@Trott
Trott deleted the minutes branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@evanlucas evanlucas evanlucas approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @joshgav @evanlucas @mhdawson @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.