GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: simplify process.memoryUsage() example code by watson · Pull Request #9560 · nodejs/node

Conversation

@watson

@watson watson commented Nov 12, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Using util.inspect doesn't change the output in this case

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@watson
doc: simplify process.memoryUsage() example code
cf17cbf 
Using util.inspect doesn't change the output in this case
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem. labels Nov 12, 2016
@MylesBorins MylesBorins added lts-watch-v4.x labels Nov 12, 2016
@MylesBorins

MylesBorins commented Nov 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

can confirm the example works as expected on v4.x -> master
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins
MylesBorins approved these changes Nov 12, 2016
View reviewed changes
Trott
Trott approved these changes Nov 12, 2016
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
silverwind
silverwind approved these changes Nov 12, 2016
View reviewed changes
cjihrig
cjihrig approved these changes Nov 12, 2016
View reviewed changes
addaleax
addaleax approved these changes Nov 12, 2016
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@silverwind

silverwind commented Nov 13, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed in 4b35f25.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@silverwind silverwind closed this Nov 13, 2016
silverwind pushed a commit that referenced this pull request Nov 13, 2016
@watson @silverwind
doc: simplify process.memoryUsage() example code
4b35f25 
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@watson
watson deleted the patch-1 branch November 13, 2016 09:25
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@watson Myles Borins
doc: simplify process.memoryUsage() example code
475fe96 
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@watson Myles Borins
doc: simplify process.memoryUsage() example code
f4c175b 
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Nov 18, 2016
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@watson @MylesBorins
doc: simplify process.memoryUsage() example code
653f092 
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@watson @addaleax
doc: simplify process.memoryUsage() example code
92bd19e 
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Nov 22, 2016
v6.9.2 proposal #9735
Merged
v4.7.0 proposal #9736
Merged
@tamsky tamsky mentioned this pull request May 30, 2017
doc/api/process: remove superfluous util.inspect() nodejs/node-v0.x-archive#25878
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@silverwind silverwind silverwind approved these changes
@MylesBorins MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@watson @MylesBorins @silverwind @Trott @addaleax @cjihrig @mmg131440 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.