GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(ncu-ci)!: require `--certify-safe` flag by aduh95 · Pull Request #798 · nodejs/node-core-utils

Conversation

@aduh95

@aduh95 aduh95 commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Or ensure the PR has received at least one approving review since last time it was pushed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
feat(ncu-ci): require --certify-safe flag
55e4f43 
Or ensure the PR has received at least one approving review since last
time it was pushed.
anonrig
anonrig reviewed Apr 24, 2024
View reviewed changes
Comment thread lib/ci/run_ci.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/ci/run_ci.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
add test
a2a6465
@targos targos mentioned this pull request Apr 24, 2024
Remove triagers the ability to run CI nodejs/admin#862
Closed
mcollina
mcollina approved these changes Apr 24, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anonrig
anonrig approved these changes Apr 24, 2024
View reviewed changes
benjamingr
benjamingr approved these changes Apr 24, 2024
View reviewed changes
MoLow
MoLow approved these changes Apr 24, 2024
View reviewed changes
BridgeAR
BridgeAR approved these changes Apr 24, 2024
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
fix tests
cd5ca9a
@aduh95 aduh95 changed the title feat(ncu-ci): require --certify-safe flag feat(ncu-ci)!: require --certify-safe flag Apr 24, 2024
MoLow
MoLow approved these changes Apr 24, 2024
View reviewed changes
@aduh95
aduh95 merged commit a5213cd into nodejs:main Apr 24, 2024
@aduh95
aduh95 deleted the run-ci-certify-safe branch April 24, 2024 18:45
@github-actions github-actions Bot mentioned this pull request Apr 19, 2024
chore(main): release 5.0.0 #795
Merged
@joyeecheung

joyeecheung commented Apr 26, 2024

Copy link
Copy Markdown
Member

This is currently a bit too restrictive - it should add an exceptions to collaborators otherwise even a collaborator cannot use the label to run the CI wihout an approving review (or after they've pushed a new commit), see nodejs/node#52692
benjamingr, ovflowd, and mcollina reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ovflowd

ovflowd commented May 2, 2024

Copy link
Copy Markdown
Member

@aduh95 do you intend to make a patch based on what @joyeecheung mentioned? 👀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina added a commit that referenced this pull request May 2, 2024
@mcollina
Revert "feat(ncu-ci)!: require --certify-safe flag (#798)"
c593c14 
This reverts commit a5213cd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@aduh95 @joyeecheung @ovflowd @mcollina @benjamingr @anonrig @MoLow @BridgeAR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.