GeezerVison

Copy link

Copy Markdown

Contributor

greptile-apps[bot] reacted with thumbs up emoji

Boulea7 requested a review from a team as a code owner August 10, 2026 18:01

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

Boulea7 marked this pull request as draft August 11, 2026 05:38

Boulea7 force-pushed the fix/issue-1328-untyped-json-responses branch from 9fc54da to 4243417 Compare August 11, 2026 07:46

Boulea7 marked this pull request as ready for review August 11, 2026 14:35

Copilot AI lite review requested due to automatic review settings September 26, 2026 19:42

Copilot started reviewing on behalf of Boulea7 September 26, 2026 19:42

View session

Copilot AI reviewed Sep 26, 2026

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mromaszewicz approved these changes Sep 28, 2026

View reviewed changes

15 checks passed

Under schema-merging-behavior v1, an allOf member that is a $ref is
embedded in a struct, whatever its type. encoding/json flattens only an
embedded struct, and encodes an embedded field of any other type under a
key named after the type. So when the member is untyped, a primitive,
an array or a map, the value went out as {"Name": "x"} instead of "x",
and decoding the value the spec describes failed, or for a map left it
empty (oapi-codegen#2590).

- An allOf of one such $ref, next to members that add no fields (the
  "decorate a $ref" idiom, with a description or nullable: true), is
  now the member's type, as under v2: `type Wrap = Name`, `One *Name`.
- An untyped member places no constraint and carries no value of its
  own, so it never decides the composition's type: a primitive, array
  or map member next to it is the composition's type, and a
  composition of only untyped members is the first one's type.
  Whenever another member adds fields or brings a type of its own, an
  untyped member keeps its embedded field, so code that sets it still
  compiles, but is tagged json:"-": it used to add an "Untyped" key to
  every object.

A member is classified by the type the generator declares for the
schema it refers to. It is generated in a context of its own, whose
merge frames are copies, so that generating it can't tell a composition
in progress that something referred back to it, and each classification
is remembered in the context: a member that is itself an allOf of a
$ref would otherwise be generated twice per link, and a chain of such
compositions took time exponential in its length. A member whose type
may carry JSON methods the struct inherits (time.Time,
openapi_types.UUID, an x-go-type naming a type or an interface with
methods) is embedded as before, and so is a member whose type would
make a cycle of aliases (`type Root = Arr` with `type Arr = []Root`),
which Go rejects.

servers/strict/responsebody_v1 and the v1 case of
TestStrictServerComposedResponseReceiverCompatibility recorded the old
shape. Those allOf responses are now the untyped member's type, which a
strict response carries in a Body field (oapi-codegen#2514), as under v2 and v3,
and they send the value itself.

The aggregate matrix harness's echo now fills a Body-wrapped strict
envelope, so a shape with an interface-typed body runs at every
position. The matrix's allof_array, allof_default and
allof_unique_items shapes no longer mark v1 broken, since it now
round-trips them. New shapes cover a map member, an untyped member,
two untyped members, an untyped member next to a map, and an untyped
member next to properties. An allOf whose member is an inline array
(allof_recursive_array) is a different v1 bug, and stays marked.

Fixes oapi-codegen#2590

Co-Authored-By: Claude Fable 5.1 <[email protected]>

Under schema-merging-behavior v1, an allOf member that is a $ref is
embedded in a struct, whatever its type. encoding/json flattens only an
embedded struct, and encodes an embedded field of any other type under a
key named after the type. So when the member is untyped, a primitive,
an array or a map, the value went out as {"Name": "x"} instead of "x",
and decoding the value the spec describes failed, or for a map left it
empty (#2590).

- An allOf of one such $ref, next to members that add no fields (the
  "decorate a $ref" idiom, with a description or nullable: true), is
  now the member's type, as under v2: `type Wrap = Name`, `One *Name`.
- An untyped member places no constraint and carries no value of its
  own, so it never decides the composition's type: a primitive, array
  or map member next to it is the composition's type, and a
  composition of only untyped members is the first one's type.
  Whenever another member adds fields or brings a type of its own, an
  untyped member keeps its embedded field, so code that sets it still
  compiles, but is tagged json:"-": it used to add an "Untyped" key to
  every object.

A member is classified by the type the generator declares for the
schema it refers to. It is generated in a context of its own, whose
merge frames are copies, so that generating it can't tell a composition
in progress that something referred back to it, and each classification
is remembered in the context: a member that is itself an allOf of a
$ref would otherwise be generated twice per link, and a chain of such
compositions took time exponential in its length. A member whose type
may carry JSON methods the struct inherits (time.Time,
openapi_types.UUID, an x-go-type naming a type or an interface with
methods) is embedded as before, and so is a member whose type would
make a cycle of aliases (`type Root = Arr` with `type Arr = []Root`),
which Go rejects.

servers/strict/responsebody_v1 and the v1 case of
TestStrictServerComposedResponseReceiverCompatibility recorded the old
shape. Those allOf responses are now the untyped member's type, which a
strict response carries in a Body field (#2514), as under v2 and v3,
and they send the value itself.

The aggregate matrix harness's echo now fills a Body-wrapped strict
envelope, so a shape with an interface-typed body runs at every
position. The matrix's allof_array, allof_default and
allof_unique_items shapes no longer mark v1 broken, since it now
round-trips them. New shapes cover a map member, an untyped member,
two untyped members, an untyped member next to a map, and an untyped
member next to properties. An allOf whose member is an inline array
(allof_recursive_array) is a different v1 bug, and stays marked.

Fixes #2590

Co-authored-by: Claude Fable 5.1 <[email protected]>