GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [FIX] tests: avoid to fork in multithread process by Xavier-Do · Pull Request #163562 · odoo/odoo

Conversation

@Xavier-Do

@Xavier-Do Xavier-Do commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Since python 3.12 python/cpython#100229, fork inside a multi threaded process will raise a warning.

We actually have another solution to get rid of the fork that was implemented in more recent versions.

part of #162438

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Xavier-Do
[FIX] tests: avoid to fork in multithread process
f3e1c25 
Since python 3.12 python/cpython#100229, fork
inside a multithreaded process will raise a warning.

We actually have another solution to get rid of the fork that was
implemented in more recent versions.
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 26, 2024
@Xavier-Do

Xavier-Do commented Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

@fw-bot ignore, already in 16.0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@C3POdoo
C3POdoo requested a review from a team April 26, 2024 14:00
@robodoo

robodoo commented Apr 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Pull request status dashboard.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xmo-odoo
xmo-odoo reviewed Apr 26, 2024
View reviewed changes

@xmo-odoo xmo-odoo left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo override=ci/security

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@d-fence

d-fence commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

robodoo r+
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@d-fence

d-fence commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

@fw-bot ignore
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fw-bot

fw-bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Forward-port disabled.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Xavier-Do Xavier-Do mentioned this pull request Apr 26, 2024
15.0 python3.12 noble xdo #162438
Closed
13 of 14 tasks
robodoo pushed a commit that referenced this pull request Apr 26, 2024
@Xavier-Do
[FIX] tests: avoid to fork in multithread process
e356d18 
Since python 3.12 python/cpython#100229, fork
inside a multithreaded process will raise a warning.

We actually have another solution to get rid of the fork that was
implemented in more recent versions.

closes #163562

Signed-off-by: Christophe Monniez (moc) <[email protected]>
@robodoo
robodoo temporarily deployed to merge April 26, 2024 16:54 Inactive
@robodoo robodoo closed this Apr 26, 2024
@fw-bot fw-bot mentioned this pull request May 10, 2024
[FW] 15.0 python3.12 noble xdo #165081
Closed
13 of 14 tasks
@fw-bot
fw-bot deleted the 15.0-avoid-multhithread-fork-xdo branch May 10, 2024 17:46
This was referenced May 13, 2024
[FW] 15.0 python3.12 noble xdo #165247
Closed
[FW] 15.0 python3.12 noble xdo #165285
Closed
[FW] 15.0 python3.12 noble xdo #165315
Closed
[FW] 15.0 python3.12 noble xdo #165571
Closed
[FW] 15.0 python3.12 noble xdo #165586
Closed
[FW] 15.0 python3.12 noble xdo #165610
Closed

This branch was previously deployed

1 inactive deployment
merge — f3e1c25a Deployed Apr 26, 2024 by robodoo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmo-odoo xmo-odoo xmo-odoo left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

RD research & development, internal work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Xavier-Do @robodoo @d-fence @fw-bot @xmo-odoo @C3POdoo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.