GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Sort lazy imports to increase stability of generated code by petterroea · Pull Request #1378 · openapi-generators/openapi-python-client

Conversation

@petterroea

@petterroea petterroea commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Lazy imports of models aren't sorted, which causes them to be unstable and change from run to run. This is distracting in situations where you have a CI action automatically generating an API client and passing it as a PR to another repo.

This PR fixes this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
plaes reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@petterroea
Sort lazy imports to increase stability
77ca206
@petterroea petterroea changed the title Sort lazy imports to increase stability Sort lazy imports to increase stability of generated code Dec 12, 2025
@dbanty dbanty changed the title Sort lazy imports to increase stability of generated code fix: Sort lazy imports to increase stability of generated code Jan 10, 2026
dbanty
dbanty approved these changes Jan 10, 2026
View reviewed changes
@dbanty
dbanty added this pull request to the merge queue Jan 10, 2026
Merged via the queue into openapi-generators:main with commit 013eddb Jan 10, 2026
22 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@knope-bot knope-bot Bot mentioned this pull request Jan 10, 2026
Release 0.28.1 #1385
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jan 10, 2026
@knope-bot
Release 0.28.1 (#1385)
454f989 
> [!IMPORTANT]
> Merging this pull request will create this release

## Fixes

- Apply required overrides from allOf schemas (#1384)
- Sort lazy imports to increase stability of generated code (#1378)

Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
@mikkelam mikkelam mentioned this pull request Feb 13, 2026
fix: sort remaining lazy imports in model template #1400
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Feb 13, 2026
@mikkelam
fix: sort remaining lazy imports in model template (#1400)
96d0047 
In [this
PR](#1378)
sorting of lazy imports was added.

I fixed the remaining issues and verified with a test. It would be super
nice to have deterministic generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbanty dbanty dbanty approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@petterroea @dbanty
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.