GeezerVison

Brings over upstream commit google/google-java-format@37171795 (google-java-format 1.8).

The bug

With javadoc formatting on (JavaFormatterOptions.formatJavadoc(true)), a banner such as

/*************************
 * Copyright
 *
 * Some Company
 *************************/

was taken for javadoc because it starts with /**: the row of asterisks moved onto a line of its own, and its paragraphs became <p> tags. The javadoc formatter has nothing to improve in a comment like that.

From upstream, with the author kept

• google/google-java-format@37171795 by cushon (Liam Miller-Cushon), commit authored by them: a comment whose fourth character is another asterisk is not javadoc. The empty() expectation of JavadocFormattingTest changes with it: /***/ stays as it is.

Added here

• bannerCommentIsNotJavadoc in JavadocFormattingTest, the banner above with javadoc formatting on.

What changes with javadoc formatting off

The same check decides how blank lines around a comment are treated. A blank line between such a banner and the declaration after it is now kept, as after any other block comment, instead of being removed as it would be after javadoc; a banner with no blank line after it stays as it was.

Checked

• The new test fails on main and passes with the change.
• ./gradlew :open-java-format:test on JDK 21: 1498 tests, all green.
• Of the 15,747 files of the JDK 21 sources, 43 format differently, by 70 blank lines more in all and no other change; every one of them is in the input, after a banner comment. Formatting main's output of those files again with this change adds nothing, apart from the four of them that change on a second run on main already.