GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: use a monotonic clock for the cache polling timeout by csviri · Pull Request #3529 · operator-framework/java-operator-sdk

Conversation

csviri commented Jul 30, 2026

Copy link

Copy Markdown

Collaborator

pollLocalCache computed its deadline with LocalTime:

var startTime = LocalTime.now();
final var timeoutTime = startTime.plus(timeoutMillis, ChronoUnit.MILLIS);
while (timeoutTime.isAfter(LocalTime.now())) {

LocalTime is a time of day and wraps at midnight, so for any call made
within timeoutMillis of 00:00 the computed deadline is earlier than
the current time. The loop body never runs and the method throws
OperatorException("Timeout of resource polling from cache for resource")
immediately, failing the update it was retrying even though the resource
would have appeared in cache. With the default 10s timeout that is a
10-second window each day.

LocalTime.now() is also wall-clock based, so an NTP step or a DST change
can shorten or extend the timeout.

Switches to System.nanoTime(), which is monotonic and has no wrap-around
concern, using overflow-safe subtraction for the comparison.

No test is added: reproducing this requires controlling the clock, and the
class is already deprecated for removal.

Part of #3517

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Copilot AI review requested due to automatic review settings

July 30, 2026 09:05

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label

Jul 30, 2026

csviri mentioned this pull request

Jul 30, 2026

Correctness AI check: collection of possible issues and related PRs #3517

Closed

13 of 16 tasks

Copilot started reviewing on behalf of csviri

July 30, 2026 09:06

View session

Copilot AI reviewed

Jul 30, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a correctness issue in PrimaryUpdateAndCacheUtils.pollLocalCache where the cache-polling timeout was computed using LocalTime (time-of-day), which can wrap at midnight and is susceptible to wall-clock adjustments. It switches the timeout tracking to a monotonic clock so the polling loop behaves consistently.

Changes:

Replace LocalTime/ChronoUnit deadline computation with a System.nanoTime()-based timeout.
Use TimeUnit.MILLISECONDS.toNanos(...) to convert the configured timeout into nanoseconds.
Remove now-unneeded java.time imports.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

...ore/src/main/java/io/javaoperatorsdk/operator/api/reconciler/PrimaryUpdateAndCacheUtils.java Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fix: use a monotonic clock for the cache polling timeout

cbac64f

`pollLocalCache` computed its deadline with `LocalTime`:

    var startTime = LocalTime.now();
    final var timeoutTime = startTime.plus(timeoutMillis, ChronoUnit.MILLIS);
    while (timeoutTime.isAfter(LocalTime.now())) {

`LocalTime` is a time of day and wraps at midnight, so for any call made
within `timeoutMillis` of 00:00 the computed deadline is *earlier* than
the current time. The loop body never runs and the method throws
`OperatorException("Timeout of resource polling from cache for resource")`
immediately, failing the update it was retrying even though the resource
would have appeared in cache. With the default 10s timeout that is a
10-second window each day.

`LocalTime.now()` is also wall-clock based, so an NTP step or a DST change
can shorten or extend the timeout.

Switches to `System.nanoTime()`, which is monotonic and has no wrap-around
concern, using overflow-safe subtraction for the comparison.

No test is added: reproducing this requires controlling the clock, and the
class is already deprecated for removal.

Copilot AI review requested due to automatic review settings

August 3, 2026 08:27

csviri force-pushed the fix/poll-local-cache-midnight-wraparound branch from 1718892 to cbac64f Compare

August 3, 2026 08:27

Copilot started reviewing on behalf of csviri

August 3, 2026 08:30

View session

Copilot AI reviewed

Aug 3, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

csviri marked this pull request as ready for review

August 3, 2026 08:38

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label

Aug 3, 2026

csviri commented

Aug 3, 2026

View reviewed changes

csviri left a comment

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

openshift-ci Bot requested review from metacosm and xstefank

August 3, 2026 08:39

csviri merged commit 4a12a39 into operator-framework:main

Aug 3, 2026

28 checks passed

Uh oh!

There was an error while loading. Please reload this page.

csviri added a commit to csviri/java-operator-sdk that referenced this pull request

Aug 3, 2026


          fix: use a monotonic clock for the cache polling timeout (operator-fr…

b1a6772

…amework#3529)

`pollLocalCache` computed its deadline with `LocalTime`:

    var startTime = LocalTime.now();
    final var timeoutTime = startTime.plus(timeoutMillis, ChronoUnit.MILLIS);
    while (timeoutTime.isAfter(LocalTime.now())) {

`LocalTime` is a time of day and wraps at midnight, so for any call made
within `timeoutMillis` of 00:00 the computed deadline is *earlier* than
the current time. The loop body never runs and the method throws
`OperatorException("Timeout of resource polling from cache for resource")`
immediately, failing the update it was retrying even though the resource
would have appeared in cache. With the default 10s timeout that is a
10-second window each day.

`LocalTime.now()` is also wall-clock based, so an NTP step or a DST change
can shorten or extend the timeout.

Switches to `System.nanoTime()`, which is monotonic and has no wrap-around
concern, using overflow-safe subtraction for the comparison.

No test is added: reproducing this requires controlling the clock, and the
class is already deprecated for removal.

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

metacosm

Awaiting requested review from metacosm

xstefank

Awaiting requested review from xstefank

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.