GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) by mrwogu · Pull Request #184 · php-opencloud/openstack

Conversation

@mrwogu

@mrwogu mrwogu commented Dec 13, 2017

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mrwogu
mrwogu force-pushed the php-7.2 branch from 985cf53 to ea4b8af Compare December 13, 2017 14:39
@mrwogu

mrwogu commented Dec 13, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Build passed successfully for:

  • 7.0
  • 7.1

but i don't know why for 7.2 i've got php-cs-fixer sugesstions on files which i didn't touch.
Maybe you have to think about php-cs-fixer update (current version is: 1.11.8)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haphan

haphan commented Dec 13, 2017

Copy link
Copy Markdown
Collaborator

I think we definitely should update some out-of-date dependencies like php-cs-fixer. Don't mind if you can update php-cs-fixer in this PR as well.

Support for php 7.2 will result in a new major version since there are some BC breaks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haphan

haphan commented Dec 13, 2017

Copy link
Copy Markdown
Collaborator

@mrwogu BaseObject sounds misleading to me, at least from a developers perspective, BaseObject often use in the context of an abstract class.

What about using StorageObject instead?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mrwogu
mrwogu force-pushed the php-7.2 branch from ea4b8af to 4b12e4b Compare December 16, 2017 20:17
@mrwogu

mrwogu commented Dec 16, 2017

Copy link
Copy Markdown
Contributor Author

Ok, i've renamed from Object to StorageObject.
php-cs-fixer has been updated and works fine now.

Unfortunately, PHPUnit is also outdated and I had to update it to a new version.
Could you check these errors?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mrwogu mrwogu mentioned this pull request Jan 6, 2018
Refactoring and fixes for PHP 7.2 #188
Closed
@mrwogu mrwogu changed the title PHP 7.2 Compatibility PHP 7.2 Compatibility (+ updated php-cs-fixer & PHPUnit) Jan 6, 2018
@mrwogu
mrwogu force-pushed the php-7.2 branch from 9a809c5 to 61e3826 Compare January 7, 2018 20:36
@nicolasmure nicolasmure mentioned this pull request Jan 14, 2018
PHP 7.2 support #192
Closed
@mrwogu
mrwogu force-pushed the php-7.2 branch 3 times, most recently from d6ac9a5 to 0a44efa Compare January 28, 2018 07:50
@mrwogu

mrwogu commented Jan 28, 2018

Copy link
Copy Markdown
Contributor Author

@haphan could you merge this into php-opencloud:php-7.2?
I also rebased my branch with master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haphan

haphan commented Feb 3, 2018

Copy link
Copy Markdown
Collaborator

Great works @mrwogu but I think commits got messed up during rebase.

Can you try to rebase it again?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

haphan and others added 11 commits February 3, 2018 17:09
@haphan @mrwogu
Added php7.2
9b53613
@mrwogu
Renamed model Object to StorageObject
8250877
@mrwogu
Updated php-cs-fixer to 2.9.0 Speechless
3b5e574
@mrwogu
Fixed PSR2 php-cs-fixer rules
3b618fc
@mrwogu
Updated PHPUnit to 6.5 (stable)
dc927f4
@mrwogu
Updated tests to use new version PHPUnit
a5916e8
@mrwogu
Fixed PHPUnit tests
c747738
@mrwogu
Removed return type for two methods in AbstractResource
546ff44
@mrwogu
Updated docks & readme
d21c534
@mrwogu
Fixed code to PSR2 compatibility
fbddef5
@mrwogu
Fixed: Count returns 1 on StdClass object
f837c8e
@mrwogu
mrwogu force-pushed the php-7.2 branch from 0a44efa to f837c8e Compare February 3, 2018 16:10
@mrwogu

mrwogu commented Feb 3, 2018

Copy link
Copy Markdown
Contributor Author

@haphan done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haphan
haphan force-pushed the php-7.2 branch from a6e9036 to cdfcd5e Compare February 4, 2018 01:27
@haphan
Update README.md
5e03d16
haphan added 4 commits February 5, 2018 11:28
@haphan
Added php_cs config
78441f1
@haphan
Updated BC breaks notice and version guidance
a29d634
@haphan
Added strict mode, increase assertion count instead of assert true
b6ed2cd
@haphan
Updated php-cs-fixer
756a8f8
@haphan
haphan merged commit 2346777 into php-opencloud:php-7.2 Feb 5, 2018
@haphan

haphan commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

@mrwogu Awesome works! 🎸

I've made only minor improvements to the README and php-cs-fixer.

Branch 2.0 will now contain version 2.x and master for 3.x.

mrwogu and nicolasmure reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aliukevicius aliukevicius mentioned this pull request Feb 27, 2018
Update openstack version to ^3.0 sausin/laravel-ovh#3
Merged
@kslr kslr mentioned this pull request Feb 28, 2018
supprt php7.2.2 sausin/laravel-ovh#4
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mrwogu @haphan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.