GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Refactoring and fixes for PHP 7.2 by noo-zh · Pull Request #188 · php-opencloud/openstack

Conversation

@noo-zh

@noo-zh noo-zh commented Dec 21, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This solves issue 181.

Fixes:

  • fix incompatible declaration of OpenStack\Common\Resource\ResourceInterface::populateFromResponse
  • rename OpenStack\ObjectStore\v1\Models\Object to OpenStack\ObjectStore\v1\Models\ObjectEntity due to new object typehint
  • refactor self typehints in child classes

Because of renaming Object -> ObjectEntity, this should be a candidate for v3.0.0 release.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
phansys reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
noo-zh added 2 commits December 21, 2017 03:05
@noo-zh
Fix bug with incompatible class definition and also refactor the code…
3f5126c 
… for PHP 7.2 compatibility.
@noo-zh
Fix incompatible code for PHP 7.2
50e2fce
@mrwogu

mrwogu commented Jan 6, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@noo-zh you didn't build it under PHP 7.2 in travis. Your repo does not work.
Look here: #184
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@noo-zh
Add PHP 7.2 to Traviswq
fa0d252
@noo-zh

noo-zh commented Jan 6, 2018

Copy link
Copy Markdown
Author

@mrwogu I see. Travis config updated. It seems only tests may be out of date. I actually already use my branch in production and everything works well (of course, I don't use all features but still).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
noo-zh added 5 commits January 6, 2018 16:37
@noo-zh
Fix to code standard
ebe1faf
@noo-zh
Update php-cs-fixer
ccd323c
@noo-zh
Update Json patch
f1c6db7
@noo-zh
Update travis config: remove php-cs-fixer --level argument (not suppo…
8782d72 
…rted any more)
@noo-zh
Fix to code standard (revert previous change)
e6edb16
@haphan

haphan commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

Version 3.0 should be compatible with php 7.2 now thanks to #184
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@haphan haphan closed this Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@noo-zh @mrwogu @haphan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.