GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow unicode variable names by aidabeorn · Pull Request #540 · phpdotenv/phpdotenv

Conversation

@aidabeorn

@aidabeorn aidabeorn commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

This PR should allow Unicode variable names in .env files to match how eg. Python-dotenv does it.

The main purpose is to allow internationalized environment variablenames as #519 asked about.

Though a niche use-case, many government contracts require certain things to be in the country's primary language(s), hence this PR would permit those projects to utilize phpdotenv.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aidabeorn added 3 commits October 6, 2022 19:34
@aidabeorn
Unit tests
9bac259
@aidabeorn
Change regex to permit international characters
c846285
@aidabeorn
Remove test that denies use of unicode characters
d994f1d
@GrahamCampbell GrahamCampbell added the hacktoberfest-accepted label Oct 16, 2022
GrahamCampbell added a commit that referenced this pull request Oct 16, 2022
@GrahamCampbell @aidabeorn
Add support for unicode variable names
d1ef2c4 
Closes #540

Co-Authored-By: Thor Erik <[email protected]>
@GrahamCampbell GrahamCampbell mentioned this pull request Oct 16, 2022
[5.5] Add support for unicode variable names #546
Merged
@GrahamCampbell GrahamCampbell closed this in #546 Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aidabeorn @GrahamCampbell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.