GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Reject unrelated paths early in determineChangedProps by maoxor · Pull Request #4103 · plotly/dash ConversationAddresses #4032 (it makes this much cheaper, but it's still a scan, so I'm leaving the issue open for you to decide). Components whose type sets This keeps the scan and makes it cheap:
The selector returns the same thing as before. NumbersI added a benchmark scenario,
For reference, In the profile of the new scenario, Why not an indexThe issue suggests indexing
A rebuilt index wins with many flagged components, but it's about twice as slow as today with a single Testing
Contributor Checklist
optionals
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsA component whose type sets dashChildrenUpdate (dcc.Tabs, several DMC types) walks all of layoutHashes on every store update, and isFirstLevelPropsChild split both paths for each entry. With many such components mounted, this was the top of the CPU profile. Check the path prefix with startsWith before allocating anything, and walk the keys instead of building an entry pair for each one. The result of the selector does not change. Add a benchmark scenario for this case and unit tests for the selector.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
4 tasks done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |