GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add notifier boolean configuration by silversonicaxel · Pull Request #7730 · plotly/plotly.js

Conversation

@silversonicaxel

@silversonicaxel silversonicaxel commented Mar 23, 2026

Copy link
Copy Markdown

This PR is intended to allow the configuration for displaying or not the notifiers in the top - right area of the viewport.

This is related to the issue #7729 .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Alessandro Rabitti added 2 commits March 23, 2026 09:54
Alessandro Rabitti
Add notifier boolean configuration
41faeeb
Alessandro Rabitti
Add draftlog for PR plotly#7730
d6e9036
@silversonicaxel silversonicaxel mentioned this pull request Mar 23, 2026
[FEATURE]: property to disable the notifier #7729
Closed
@camdecoster camdecoster self-assigned this Mar 23, 2026
@camdecoster

camdecoster commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@silversonicaxel would you be able to rebase your branch such that the linting changes are all in one commit? It makes it hard to review when they're all mixed in.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@camdecoster camdecoster assigned silversonicaxel and unassigned camdecoster Mar 23, 2026
@silversonicaxel
silversonicaxel force-pushed the feature-notifier branch 8 times, most recently from 2d5a55a to 0171b04 Compare March 24, 2026 07:07
Alessandro Rabitti
Undo lint
5692404
@silversonicaxel
silversonicaxel force-pushed the feature-notifier branch from 0171b04 to 5692404 Compare March 24, 2026 07:10
@silversonicaxel

silversonicaxel commented Mar 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

@camdecoster

I undid most of them, (sorry I had global linter in the IDE)

But the last left, seem legit to me.

And project linting was not complaining, or fixing it in its execution.

    "lint": "npx @biomejs/biome lint",
    "lint-fix": "npx @biomejs/biome format ./test/image/mocks --write; npx @biomejs/biome lint --write || true",
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@camdecoster

camdecoster commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

I'm totally fine with linting. It just helps to move all those changes into one commit, then make the actual PR changes in separate commits. I'll take a look at things right now, but you could make a final commit to lint after the review is complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

camdecoster
camdecoster approved these changes Mar 25, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. You can add back your linting changes if you'd like.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

silversonicaxel reacted with hooray emoji
All reactions
  • 🎉 1 reaction
Comment thread src/lib/notifier.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@camdecoster

camdecoster commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

FYI, the test failures are unrelated to your changes.

silversonicaxel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Alessandro Rabitti
Add optional chaining condition in notifier.js
97d8f09
@silversonicaxel

silversonicaxel commented Mar 25, 2026

Copy link
Copy Markdown
Author

Working for me. You can add back your linting changes if you'd like.

I would prefer another PR, where lint rules are applied stricter. Otherwise I would feel to push my IDE lint rules to just a few bunch of files.

camdecoster reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@camdecoster
Update changelog
33f6298
@camdecoster
camdecoster merged commit 2dcd2c9 into plotly:master Mar 25, 2026
4 of 5 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@archmoj archmoj mentioned this pull request Mar 26, 2026
feat: Add US location name lookup choropleth, scattergeo traces #7731
Merged
@emilykl emilykl mentioned this pull request May 13, 2026
[BUG]: Some recently-added config options in plotly.js raise a warning in plotly.py plotly/plotly.py#5594
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@silversonicaxel silversonicaxel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@silversonicaxel @camdecoster
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.