GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Add notifier boolean configuration by silversonicaxel · Pull Request #7730 · plotly/plotly.js ConversationThis PR is intended to allow the configuration for displaying or not the notifiers in the top - right area of the viewport. This is related to the issue #7729 .
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
silversonicaxel
force-pushed
the
feature-notifier
branch
8 times, most recently
from
2d5a55a to
0171b04
Compare
silversonicaxel
force-pushed
the
feature-notifier
branch
from
0171b04 to
5692404
Compare
|
There was an error while loading. Please reload this page.
|
I undid most of them, (sorry I had global linter in the IDE) But the last left, seem legit to me. And project linting was not complaining, or fixing it in its execution. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm totally fine with linting. It just helps to move all those changes into one commit, then make the actual PR changes in separate commits. I'll take a look at things right now, but you could make a final commit to lint after the review is complete. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Working for me. You can add back your linting changes if you'd like.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
FYI, the test failures are unrelated to your changes. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I would prefer another PR, where lint rules are applied stricter. Otherwise I would feel to push my IDE lint rules to just a few bunch of files. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.