GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Share chart button by emilykl · Pull Request #7802 · plotly/plotly.js

Conversation

@emilykl

@emilykl emilykl commented May 14, 2026 •
edited by camdecoster
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Modify the existing sendDataToCloud modebar button to share the chart via Plotly Cloud rather than Chart Studio.

The button remains disabled by default. Note that the Plotly Cloud endpoint for receiving charts is not yet functional, so the full sharing feature is not yet ready, but the UI can be previewed by setting showSendToCloud: true in the plot config.

Since the Chart Studio website is no longer online, the existing "share to Cloud" logic was not functional, so this should not be a breaking change.

Codepen: https://codepen.io/marthacryan/pen/dPOmREK

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
emilykl added 4 commits May 14, 2026 13:15
@emilykl
add button placeholder which shows chart JSON
42c9601
@emilykl
add icon
8ce5512
@emilykl
use existing sendChartToCloud function
ad9ddfc
@emilykl
update plot-schema
100da7b
@emilykl
emilykl force-pushed the upload-to-cloud-proto branch from a487ce9 to 100da7b Compare May 14, 2026 17:16
@camdecoster camdecoster assigned emilykl May 20, 2026
@emilykl emilykl changed the title draft Share chart button May 20, 2026
@marthacryan
Update approach to use postMessage and wait for ready signal before s…
82f5437 
…ending data to cloud
@marthacryan
marthacryan marked this pull request as ready for review May 28, 2026 20:38
@marthacryan
Merge branch 'master' of github.com:plotly/plotly.js into upload-to-c…
fddd50e 
…loud-proto
@marthacryan
marthacryan marked this pull request as draft May 28, 2026 20:40
@marthacryan marthacryan self-assigned this May 28, 2026
marthacryan added 2 commits May 28, 2026 14:12
@marthacryan
Create a confirmation dialog
ba91b11
@marthacryan
Add default URL for plotlyServerURL
717fc26
emilykl
emilykl commented May 29, 2026
View reviewed changes
Comment thread src/components/modebar/cloud_confirm.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl commented May 29, 2026
View reviewed changes
Comment thread src/plot_api/plot_config.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl commented May 29, 2026
View reviewed changes
Comment thread src/plots/plots.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl commented May 29, 2026
View reviewed changes
Comment thread src/plots/plots.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
marthacryan and others added 4 commits June 9, 2026 15:06
@marthacryan
Update string to indicate success
8774b9c
@marthacryan @emilykl
Update src/plot_api/plot_config.js
13b8f12 
Co-authored-by: Emily KL <[email protected]>
@marthacryan
Add localization
a44f6ef
@marthacryan
Address review
836d24c
@marthacryan
marthacryan marked this pull request as ready for review June 11, 2026 02:33
@marthacryan
Update default cloud URL
1f47ebd
emilykl
emilykl commented Jun 11, 2026
View reviewed changes
Comment thread src/components/modebar/cloud_confirm.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
marthacryan and others added 4 commits June 11, 2026 13:37
@marthacryan @emilykl
Update src/components/modebar/cloud_confirm.js
83deac2 
Co-authored-by: Emily KL <[email protected]>
@marthacryan
Set default to false for showSendToCloud
852dc1f
@marthacryan
Merge changes
4a71e43
@marthacryan
Update plot-schema in dist
ff34976
emilykl
emilykl commented Jun 15, 2026
View reviewed changes
Comment thread src/plots/plots.js Outdated
Comment on lines 204 to 205
plots.sendDataToCloud = function(gd) {
var baseUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL;

@emilykl emilykl Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to pass in baseUrl / serverUrl as an argument, so that we don't have to duplicate this (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL logic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
emilykl
emilykl commented Jun 15, 2026
View reviewed changes
Comment thread src/plots/plots.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl commented Jun 15, 2026
View reviewed changes
Comment thread src/components/modebar/buttons.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl commented Jun 15, 2026
View reviewed changes
Comment thread test/plot-schema.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl added 2 commits June 15, 2026 16:20
@emilykl
Revert "Update plot-schema in dist"
e5933bd 
This reverts commit ff34976.
@emilykl
update test/plot-schema.json
c1b7122
@emilykl
emilykl force-pushed the upload-to-cloud-proto branch from 396b681 to c1b7122 Compare June 15, 2026 20:21
emilykl
emilykl commented Jun 15, 2026
View reviewed changes
Comment thread src/components/modebar/cloud_confirm.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl
emilykl commented Jun 15, 2026
View reviewed changes
Comment thread src/components/modebar/buttons.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
marthacryan and others added 7 commits June 15, 2026 18:42
@marthacryan
Update default URL for upload to empty string until plotly cloud endp…
c28c434 
…oint is up
@marthacryan
Merge branch 'upload-to-cloud-proto' of github.com:plotly/plotly.js i…
da868be 
…nto upload-to-cloud-proto
@marthacryan @emilykl
Update src/components/modebar/cloud_confirm.js
bf8971a 
Co-authored-by: Emily KL <[email protected]>
@marthacryan @emilykl
Update src/components/modebar/buttons.js
ada548c 
Co-authored-by: Emily KL <[email protected]>
@marthacryan
Move validation logic to prevent dialog opening for invalid URLs
0ee9501
@marthacryan
Merge branch 'upload-to-cloud-proto' of github.com:plotly/plotly.js i…
299d9a5 
…nto upload-to-cloud-proto
@marthacryan
Update default for test plot schema
5a7a7af
@marthacryan
marthacryan merged commit 81f20cc into master Jun 17, 2026
29 of 31 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@marthacryan
marthacryan deleted the upload-to-cloud-proto branch June 17, 2026 17:29
archmoj
archmoj reviewed Jun 18, 2026
View reviewed changes
Comment thread src/plots/plots.js
plots.layoutAttributes = require('./layout_attributes');

var commandModule = require('./command');
const { server } = require('karma');

@archmoj archmoj Jun 18, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import of a dev-dependency is not used in the source code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
emilykl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@archmoj archmoj mentioned this pull request Jun 18, 2026
An unused dev-dependency is loaded in the source code #7847
Closed
@archmoj

archmoj commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR is missing a draft log. cc: @emilykl
emilykl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@archmoj archmoj mentioned this pull request Jun 18, 2026
fix: Remove mistakenly added import #7848
Merged
camdecoster added a commit that referenced this pull request Jun 18, 2026
@camdecoster
Add missing draftlog for #7802
ad776f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@archmoj archmoj archmoj left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@emilykl emilykl

@marthacryan marthacryan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emilykl @archmoj @marthacryan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.