GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove `*src` attributes by emilykl · Pull Request #7829 · plotly/plotly.js

Conversation

@emilykl

@emilykl emilykl commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Addresses #7623

Schema attributes ending in src existed only to work with Chart Studio features, so they are no longer necessary

This PR:

  • Removes all *src attributes and associated logic
  • Removes layout.hideSources attribute which was also only needed for Chart Studio
  • Updates tests accordingly (including deleting these removed attributes from image mocks)
  • Updates typegen script
  • Regenerates plot-schema.json and generated types

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
emilykl added 5 commits June 8, 2026 18:21
@emilykl
remove src attr references
068e235
@emilykl
remove src attr handling from typegen step
c5d2b96
@emilykl
remove src attributes from mock
6f0e111
@emilykl
remove layout.hidesources attr
299e8af
@emilykl
regenerate plot schema
05501b7
@emilykl
emilykl force-pushed the remove-src-attrs branch from 2bc318f to 05501b7 Compare June 8, 2026 22:25
@emilykl
add draftlogs
eb72222
emilykl
emilykl commented Jun 9, 2026
View reviewed changes
Comment thread draftlogs/7812_remove.md

@emilykl emilykl Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second draftlog is for PR #7812, which we forgot to add a draftlog for at the time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
archmoj
archmoj reviewed Jun 9, 2026
View reviewed changes
Comment thread src/plots/plots.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/jasmine/tests/plots_test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/jasmine/tests/plots_test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread draftlogs/7623_change.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
emilykl and others added 3 commits June 9, 2026 15:01
@emilykl @archmoj
remove now-redundant argument from Plots.graphJson call
e31670a 
Co-authored-by: Mojtaba Samimi <[email protected]>
@emilykl
add explicit defaults for graphJson function
17ee326
@emilykl
clean up draftlogs
1c903d2
@emilykl
emilykl requested a review from camdecoster June 9, 2026 19:16
camdecoster
camdecoster approved these changes Jun 9, 2026
View reviewed changes
Comment thread draftlogs/7623_change.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@emilykl
emilykl merged commit d01c5fe into v4.0 Jun 10, 2026
83 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@emilykl
emilykl deleted the remove-src-attrs branch June 10, 2026 16:25
@emilykl emilykl mentioned this pull request Jun 15, 2026
Share chart button #7802
Merged
@jqnatividad jqnatividad mentioned this pull request Oct 28, 2026
Upgrade bundled plotly.js to from 3.x to 4.x; releasing 0.15.0 plotly/plotly.rs#437
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes
+1 more reviewer
@archmoj archmoj archmoj left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emilykl @camdecoster @archmoj
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.