GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add error handling for relpath ValueError by SitiSchu · Pull Request #2531 · pre-commit/pre-commit

Conversation

@SitiSchu

@SitiSchu SitiSchu commented Sep 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #2530

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SitiSchu
Add error handling for relpath ValueError, fixes #2530
4aa4382
@SitiSchu
SitiSchu force-pushed the fix-value-error branch from d04e8c4 to 4aa4382 Compare September 28, 2022 22:36
@m-rsha m-rsha mentioned this pull request Oct 30, 2022
Add relpath test for Windows error coverage #2571
Open
ghost
ghost approved these changes May 31, 2024
View reviewed changes
@asottile

asottile commented Sep 6, 2025

Copy link
Copy Markdown
Member

#2571 is slightly closer to fixing this -- but needs an additional assertion cc @m-rsha
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile asottile closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueError on Windows when config is on a different drive than the git repo

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@SitiSchu @asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.