GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add `relpath` test for Windows error coverage by m-rsha · Pull Request #2571 · pre-commit/pre-commit

Conversation

@m-rsha

@m-rsha m-rsha commented Oct 30, 2022

Copy link
Copy Markdown
Contributor

Fixes #2531 , beep boop.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SitiSchu @m-rsha
Add error handling for relpath ValueError, fixes pre-commit#2530
6a11b80
@m-rsha
m-rsha force-pushed the test-relpath branch 2 times, most recently from 8ad9492 to 7454d6c Compare October 30, 2022 23:58
@m-rsha
Add relpath test for Windows error coverage
3a3fe94
@m-rsha
m-rsha force-pushed the test-relpath branch from 7454d6c to 3a3fe94 Compare October 31, 2022 00:06
@asottile asottile mentioned this pull request Sep 6, 2025
Add error handling for relpath ValueError #2531
Closed
@asottile

asottile commented Sep 6, 2025

Copy link
Copy Markdown
Member

@m-rsha I think this needs an assertion showing that it preserves the value -- and maybe some more realistic inputs / outputs to demonstrate it's trying to handle windows paths on different drives?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@m-rsha @asottile @SitiSchu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.