GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add fail-fast argument for run command by JulianMaurin · Pull Request #3528 · pre-commit/pre-commit

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Hello 👋

This is my first contribution to this repository. Please let me know if I missed any requirements. I’ll be glad to adjust.

Currently, fail-fast is enforced only via configuration. This pull request adds a --fail-fast argument to the run command, so it can be toggled at runtime (e.g. enabled in CI but disabled locally).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JulianMaurin
JulianMaurin force-pushed the feat/fail-fast branch from 5c2d558 to 6e446e7 Compare August 25, 2025 22:09
@JulianMaurin @asottile
Add fail-fast argument for run command
c78f248
@asottile
asottile force-pushed the feat/fail-fast branch from 6e446e7 to c78f248 Compare September 6, 2025 18:14
asottile
asottile approved these changes Sep 6, 2025
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally please create an issue to discuss first. I'm not sure I see the value in this but it's simple enough and maybe could be useful. it's just kinda weird that there's three slightly different ways to do this but shrugs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@asottile
asottile enabled auto-merge September 6, 2025 18:17
@asottile
asottile merged commit 954cc3b into pre-commit:main Sep 6, 2025
@j178 j178 mentioned this pull request Oct 15, 2025
Add prek run --fail-fast flag j178/prek#896
Closed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 14, 2025
ECG Bot @tmeijn
build(deps): update pre-commit to v4.4.0
9e95828
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [pre-commit](https://github.com/pre-commit/pre-commit) | minor | `4.3.0` -> `4.4.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

### [`v4.4.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#440---2025-11-08)

[Compare Source](pre-commit/pre-commit@v4.3.0...v4.4.0)

\==================

##### Features

- Add `--fail-fast` option to `pre-commit run`.
  - [#&#8203;3528](pre-commit/pre-commit#3528) MR by [@&#8203;JulianMaurin](https://github.com/JulianMaurin).
- Upgrade `ruby-build` / `rbenv`.
  - [#&#8203;3566](pre-commit/pre-commit#3566) MR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3565](pre-commit/pre-commit#3565) issue by [@&#8203;MRigal](https://github.com/MRigal).
- Add `language: unsupported` / `language: unsupported_script` as aliases
  for `language: system` / `language: script` (which will eventually be
  deprecated).
  - [#&#8203;3577](pre-commit/pre-commit#3577) MR by [@&#8203;asottile](https://github.com/asottile).
- Add support docker-in-docker detection for cgroups v2.
  - [#&#8203;3535](pre-commit/pre-commit#3535) MR by [@&#8203;br-rhrbacek](https://github.com/br-rhrbacek).
  - [#&#8203;3360](pre-commit/pre-commit#3360) issue by [@&#8203;JasonAlt](https://github.com/JasonAlt).

##### Fixes

- Handle when docker gives `SecurityOptions: null`.
  - [#&#8203;3537](pre-commit/pre-commit#3537) MR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3514](pre-commit/pre-commit#3514) issue by [@&#8203;jenstroeger](https://github.com/jenstroeger).
- Fix error context for invalid `stages` in `.pre-commit-config.yaml`.
  - [#&#8203;3576](pre-commit/pre-commit#3576) MR by [@&#8203;asottile](https://github.com/asottile).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JulianMaurin @asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.