GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Return an error for invalid --repo by mxr · Pull Request #3701 · pre-commit/pre-commit

Return an error for invalid --repo #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

asottile merged 1 commit into main from autoupdate-repos

Jul 21, 2026

+14 −5

Merged

Return an error for invalid --repo #3701

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

1d811d9

Return an error for invalid --repo

mxr May 28, 2026

File filter

Filter by extension .py (2) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

7 changes: 7 additions & 0 deletions 7 pre_commit/commands/autoupdate.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -175,6 +175,13 @@ def autoupdate(
		repo for repo in load_config(config_file)['repos']
		if repo['repo'] not in {LOCAL, META}
		]
		missing_repos = set(repos) - {r['repo'] for r in config_repos}
		if missing_repos:
		output.write_line(
		f'repos ({", ".join(sorted(missing_repos))}) were '
		f'not found in {config_file}',
		)
		return 1

		rev_infos: list[RevInfo \| None] = [None] * len(config_repos)
		jobs = jobs or xargs.cpu_count() # 0 => number of cpus
Expand Down

12 changes: 7 additions & 5 deletions 12 tests/commands/autoupdate_test.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -260,8 +260,8 @@ def test_autoupdate_out_of_date_repo_with_correct_repo_name(
		assert 'local' in after


		def test_autoupdate_out_of_date_repo_with_wrong_repo_name(
		out_of_date, in_tmpdir,
		def test_autoupdate_missing_repo_name(
Comment thread mxr marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		out_of_date, in_tmpdir, cap_out,
		):
		config = make_config_from_repo(
		out_of_date.path, rev=out_of_date.original_rev, check=False,
Expand All		@@ -270,15 +270,17 @@ def test_autoupdate_out_of_date_repo_with_wrong_repo_name(

		with open(C.CONFIG_FILE) as f:
		before = f.read()
		# It will not update it, because the name doesn't match
		ret = autoupdate(
		C.CONFIG_FILE, freeze=False, tags_only=False,
		repos=('dne',),
		repos=('dne', 'foo'),
		)
		with open(C.CONFIG_FILE) as f:
		after = f.read()
		assert ret == 0
		assert ret == 1
		assert before == after
		assert cap_out.get() == (
		f"repos (dne, foo) were not found in {C.CONFIG_FILE}\n"
		)


		def test_does_not_reformat(tmpdir, out_of_date):
Expand Down

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.