GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — wayland support by catilac · Pull Request #1337 · processing/processing4 Conversation
|
| // TODO: Currently unsupported | ||
| return 0; | ||
| } else if (Platform.get() == Platform.WINDOWS) { | ||
| // TODO: Currently unsupported | ||
| return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't sure what to do here since we don't use display handle on MacOS and windows yet.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| // TODO: need to check if x11 or wayland | ||
| return GLFWNativeWayland.glfwGetWaylandDisplay(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i'll add x11 to this if we can test in the short term. otherwise it could go in another PR.
but happy to just do it here as well. i think i just have to check for a null pointer for Wayland or X11.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| let window = AppKitWindowHandle::new(std::ptr::NonNull::new(ns_view_ptr).unwrap()); | ||
| let window = AppKitWindowHandle::new(NonNull::new(ns_view_ptr).unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tychedelia from a rust stylistic point of view, do we like removing namespacing? or better to keep it in the context of a larger program?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
| let window_handle_ptr = unsafe { NonNull::new_unchecked(window_handle as *mut c_void) }; | ||
| let window = WaylandWindowHandle::new(window_handle_ptr); | ||
|
|
||
| let display_handle_ptr = unsafe { NonNull::new_unchecked(display_handle as *mut c_void) }; | ||
| let display = WaylandDisplayHandle::new(display_handle_ptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should add a TODO here for X11 as well. But happy I figured out how to do this!~
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
511a147 to
f84f52e
Compare
|
Closing this since the work has been moved to: |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Projects
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
2 participants
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.