GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Wayland support by catilac · Pull Request #3 · processing/libprocessing

Conversation

@catilac

@catilac catilac commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Created a patch from [#1337 in Processing4](https://github.com/processing/processing4/pull/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@catilac
Wayland support
07abebb
@catilac
catilac requested a review from tychedelia November 24, 2025 15:55
@catilac catilac mentioned this pull request Nov 24, 2025
wayland support processing/processing4#1337
Closed
tychedelia
tychedelia requested changes Nov 24, 2025
View reviewed changes

@tychedelia tychedelia left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just minor comment on use of unsafe.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread renderer/src/lib.rs Outdated
let (raw_window_handle, raw_display_handle) = {
use raw_window_handle::{WaylandDisplayHandle, WaylandWindowHandle};

let window_handle_ptr = unsafe { NonNull::new_unchecked(window_handle as *mut c_void) };

@tychedelia tychedelia Nov 24, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only use the unchecked variants in situations where we control the provenance of the pointer, or at the least document the invariant in the safety information for this function. Here, I think we can do the lazy thing that I do above which is NonNull::new(ptr).unwrap()) which guarantees we'll at least panic if the caller passes us a null ptr (we probably should be returning HandleError).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@catilac catilac Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Just addressed the feedback. I am returning HandleError now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@catilac
Unwrap checked pointer, and error handling for null pointers
4023c90
@catilac
catilac requested a review from tychedelia November 25, 2025 01:12
tychedelia
tychedelia approved these changes Nov 25, 2025
View reviewed changes
@tychedelia
tychedelia merged commit 5906340 into processing:main Nov 25, 2025
@catilac
catilac deleted the 1305-wayland branch November 25, 2025 20:16
tychedelia added a commit that referenced this pull request Nov 25, 2025
@tychedelia
Add Wayland support (#3)
f7bf833 
- Implement Wayland surface creation
- Add checked pointer unwrapping and error handling for null pointers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tychedelia tychedelia tychedelia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@catilac @tychedelia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.